From owner-svn-src-head@FreeBSD.ORG  Mon Jan 23 14:13:09 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C9BB41065672;
	Mon, 23 Jan 2012 14:13:09 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net
	[IPv6:2001:7b8:2ff:146::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 82F158FC0A;
	Mon, 23 Jan 2012 14:13:09 +0000 (UTC)
Received: from [IPv6:2001:7b8:3a7:0:d887:2a58:6ed8:8aa] (unknown
	[IPv6:2001:7b8:3a7:0:d887:2a58:6ed8:8aa])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by tensor.andric.com (Postfix) with ESMTPSA id B5E465C37;
	Mon, 23 Jan 2012 15:13:08 +0100 (CET)
Message-ID: <4F1D6AF3.2030303@FreeBSD.org>
Date: Mon, 23 Jan 2012 15:13:07 +0100
From: Dimitry Andric <dim@FreeBSD.org>
Organization: The FreeBSD Project
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
	rv:10.0) Gecko/20120106 Thunderbird/10.0
MIME-Version: 1.0
To: Kostik Belousov <kostikbel@gmail.com>
References: <201201200138.q0K1cSou016739@svn.freebsd.org>
	<20120120.123256.1432718473132856309.hrs@allbsd.org>
	<CAF6rxg=VWzUcDuk_oN_wepJPejg8JnGBKm5oLXB7Y8JCW52t3w@mail.gmail.com>
	<20120123.132840.618925004528110765.hrs@allbsd.org>
	<4F1D51A0.6040405@FreeBSD.org>
	<20120123123132.GM31224@deviant.kiev.zoral.com.ua>
In-Reply-To: <20120123123132.GM31224@deviant.kiev.zoral.com.ua>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	Hiroki Sato <hrs@freebsd.org>, eadler@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r230354 - head/usr.sbin/makefs
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Jan 2012 14:13:09 -0000

On 2012-01-23 13:31, Kostik Belousov wrote:
> On Mon, Jan 23, 2012 at 01:25:04PM +0100, Dimitry Andric wrote:
...
> There is a typo in the second or condition, should it be gcc46 both times ?

Ah, sorry, that was a copy/paste error.


> Anyway, the reason to answer this message is two ask the for seemingly
> unreasonable approach of matching compiler type/version based on the
> driver name. This completely precludes anybody from using gcc installed
> not from the ports tree.

Yes, that is indeed the big problem with this approach.  Although I
think the number of people that hand-build gcc, and not use the ports
will be rather low.  :)


> Could the tests performed based on the driver version information
> instead of name ?

Probably, but then you would have to run "${CC} --version" plus some
sed/awk'ing from bsd.sys.mk.  That could add quite some extra forking
during buildworld.

It may be easier to add a COMPILER_FLAVOR (just an example name) setting
in make.conf, which can be set independently of CC, CXX and so on, to
tell which specific variant of gcc, clang etc you want to use.

The processing of that setting could happen in either sys.mk or
bsd.sys.mk, or be separated out to a bsd.compiler.mk, for instance.

In each .mk file or Makefile that needs it, the ${CC:T:M:foo} == "foo"
comparisons can then be replaced with ${COMPILER_FLAVOR} == "foo".