From owner-freebsd-net@FreeBSD.ORG  Thu May 20 18:30:09 2010
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 27A4C1065670
	for <freebsd-net@hub.freebsd.org>; Thu, 20 May 2010 18:30:09 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (unknown [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 17BEA8FC17
	for <freebsd-net@hub.freebsd.org>; Thu, 20 May 2010 18:30:09 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o4KIU81r005265
	for <freebsd-net@freefall.freebsd.org>; Thu, 20 May 2010 18:30:08 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o4KIU8TC005260;
	Thu, 20 May 2010 18:30:08 GMT (envelope-from gnats)
Date: Thu, 20 May 2010 18:30:08 GMT
Message-Id: <201005201830.o4KIU8TC005260@freefall.freebsd.org>
To: freebsd-net@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/146759: commit references a PR
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 20 May 2010 18:30:09 -0000

The following reply was made to PR kern/146759; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/146759: commit references a PR
Date: Thu, 20 May 2010 18:22:57 +0000 (UTC)

 Author: np
 Date: Thu May 20 18:22:45 2010
 New Revision: 208356
 URL: http://svn.freebsd.org/changeset/base/208356
 
 Log:
   Remove invalid assertion.
   
   Holding the adapter lock while changing the LRO settings is sufficient.
   
   PR:		kern/146759
   MFC after:	3 days
 
 Modified:
   head/sys/dev/cxgb/cxgb_main.c
 
 Modified: head/sys/dev/cxgb/cxgb_main.c
 ==============================================================================
 --- head/sys/dev/cxgb/cxgb_main.c	Thu May 20 17:30:55 2010	(r208355)
 +++ head/sys/dev/cxgb/cxgb_main.c	Thu May 20 18:22:45 2010	(r208356)
 @@ -1979,7 +1979,6 @@ cxgb_set_lro(struct port_info *p, int en
  	struct adapter *adp = p->adapter;
  	struct sge_qset *q;
  
 -	PORT_LOCK_ASSERT_OWNED(p);
  	for (i = 0; i < p->nqsets; i++) {
  		q = &adp->sge.qs[p->first_qset + i];
  		q->lro.enabled = (enabled != 0);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"