From owner-freebsd-current@FreeBSD.ORG  Sun Nov 25 22:48:25 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 9F385E73;
 Sun, 25 Nov 2012 22:48:25 +0000 (UTC)
 (envelope-from mdf356@gmail.com)
Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com
 [209.85.220.54])
 by mx1.freebsd.org (Postfix) with ESMTP id 39B868FC08;
 Sun, 25 Nov 2012 22:48:25 +0000 (UTC)
Received: by mail-pa0-f54.google.com with SMTP id bi5so1879215pad.13
 for <multiple recipients>; Sun, 25 Nov 2012 14:48:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=sbCTjGY42Ks9QL87GriqoRfU0EXsrY9EnEglxjSJFVw=;
 b=oSZEF0D3ZcGOT6m5JKopnJJM2VnfvGt5wuTgv0HEsI+rN+wBBuTlh538AOWruQZF0H
 y8tx3a/oXMDY9qz0zpHXb8BKxGpZ0UnvtLaDyDeF2qunWImAOK9fNVq0bKjb5Tv0Cks2
 C1COdSJjq6uXyPHasdKJv6j0aY1ooafMSC9z6Ve8DDO2tvLTIVz2w3KFZw/Yq7XKGPUG
 KpWPsdb7RYj93cjERQ5EODDVkg3wl7PvyDFoH6B09wfb79fVMxsatfil5jKrhPtPfM4A
 9BqHXZtuEKMzBJh7V7xt/BrEIb90Hmbt6pNpGH6w6iltuEk/WYWjtd4AEfESn7tx6ToT
 b8jg==
MIME-Version: 1.0
Received: by 10.68.233.196 with SMTP id ty4mr32575446pbc.23.1353883699489;
 Sun, 25 Nov 2012 14:48:19 -0800 (PST)
Sender: mdf356@gmail.com
Received: by 10.68.132.136 with HTTP; Sun, 25 Nov 2012 14:48:19 -0800 (PST)
In-Reply-To: <50B29B07.20808@daemonic.se>
References: <50B29B07.20808@daemonic.se>
Date: Sun, 25 Nov 2012 14:48:19 -0800
X-Google-Sender-Auth: zOKpkIe9mlqCzF7qYiRQ_IMWX5w
Message-ID: <CAMBSHm9Yyn42dn4C7=8Ft7TYAEY+cUpevq0CfbB1vfv7EhOsxg@mail.gmail.com>
Subject: Re: panic: sbuf_trim makes no sense on sbuf 0xffffff82434d8898 with
 drain
From: mdf@FreeBSD.org
To: Niclas Zeising <zeising+freebsd@daemonic.se>
Content-Type: text/plain; charset=ISO-8859-1
Cc: Alexander Motin <mav@freebsd.org>, current@freebsd.org
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Nov 2012 22:48:25 -0000

On Sun, Nov 25, 2012 at 2:26 PM, Niclas Zeising
<zeising+freebsd@daemonic.se> wrote:
> Hi!
> I consistently get this panic while trying to boot a kernel build from
> r243530.  It happens when the entropy harvesting rc.d script starts. r243380
> worked fine, I haven't tested any revisions in between. Attached is the
> backtrace from the kernel, as gotten by kgdb.  The machine uses zfs as a
> root pool, and there have been churn in this area.  To my untrained eyes,
> however, the issue seem related to hdaa.c. Please let me know if I can
> provide any more information.

r243530 added the new sysctl that is causing panic.  I'm not sure why
there's an sbuf_trim() call; there shouldn't be more than a few \n at
the end.  IMO the sbuf_trim() can be eliminated.

Alternately, the panic check can be removed and we could allow
sbuf_trim() to remove any un-emitted whitespace for an sbuf with
drain.

CC'ing mav@ who introduced the code.  (I introduced sbuf drains).

Thanks,
matthew