From owner-svn-src-all@FreeBSD.ORG Sat Jan 3 04:14:47 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5148F591 for ; Sat, 3 Jan 2015 04:14:47 +0000 (UTC) Received: from mail-ie0-f179.google.com (mail-ie0-f179.google.com [209.85.223.179]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 140F5926 for ; Sat, 3 Jan 2015 04:14:46 +0000 (UTC) Received: by mail-ie0-f179.google.com with SMTP id rp18so16782522iec.24 for ; Fri, 02 Jan 2015 20:14:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:subject:mime-version:content-type :in-reply-to:date:cc:message-id:references:to; bh=kc30ddeC7ukR78u5rIZVPuPm1zJVhiAZedu4+lsRZuk=; b=Onbb2r5BnWwKv2POReJyP0pmgI4VeNX4Cif0Q6J/DYD5J8aIKViKhzPJUJILHgYDTI aA1giQqzHatZZntjnDHRBCwrwYw19ivlIHOUQDPLMiU+lkQPKasvLlo5imdPvsXgsl/I 9CAfuQC9lssBJoefXyZ8WkMAK6mvZ3F2MHfwXGIvXvxRrABRrS+QscHo1qEXEbnnKrNo JAG3tE2cY4W5eAQczCzUE2lyKgXT7A0CideAMGL67HegUIgOavpExHQG1Gyx/OkD1UUU ci5mIvOOcXKAUE8kWP9MEKj7SrAOpiTI2AKK2xsVU4JxV498IIWlR3FiDzW0pt72il3P L6dg== X-Gm-Message-State: ALoCoQl4gS5/I9A5OHKa9PHG6mqgzOskTlxg+H5h6eX8a272vVD/NV1g3bhQAheNwElHjzjqJ86m X-Received: by 10.42.66.69 with SMTP id o5mr28684446ici.40.1420258480484; Fri, 02 Jan 2015 20:14:40 -0800 (PST) Received: from netflix-mac-wired.bsdimp.com ([50.253.99.174]) by mx.google.com with ESMTPSA id h36sm23710651iod.17.2015.01.02.20.14.39 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 02 Jan 2015 20:14:39 -0800 (PST) Sender: Warner Losh From: Warner Losh X-Google-Original-From: Warner Losh Subject: Re: svn commit: r276499 - head/sys/conf Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) Content-Type: multipart/signed; boundary="Apple-Mail=_1BC221AF-D4D6-47E4-854A-8197EB7222B2"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b3 In-Reply-To: Date: Fri, 2 Jan 2015 21:14:38 -0700 Message-Id: <5206DEA5-A5EA-48F3-B653-3E949ABE2EB1@netflix.com> References: <201501011007.t01A7wYW032884@svn.freebsd.org> <41CF0351-83A3-4D54-B308-32F310DCD3DA@gmail.com> To: Dimitry Andric X-Mailer: Apple Mail (2.1993) Cc: svn-src-head@freebsd.org, Roman Divacky , src-committers , svn-src-all@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jan 2015 04:14:47 -0000 --Apple-Mail=_1BC221AF-D4D6-47E4-854A-8197EB7222B2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Conditioning on the compiler version is actually rather easy, especially since the number of affected files is so small. It=E2=80=99s an issue when people build the old way on old systems, = which is still a lot more popular than you might think. MFC has nothing to do with the problem. Over the years we=E2=80=99ve fixed dozens of = bugs like this that prevented people from building on older systems and I=E2=80=99d like to avoid breaking things needlessly. I=E2=80=99m happy to do the work to make this happen, if you=E2=80=99re = OK with my backing out these couple of changes. Warner > On Jan 2, 2015, at 1:23 PM, Dimitry Andric wrote: >=20 > Hm, conditionalizing this on the compiler version is rather ugly. = Isn't > this only relevant when we do an MFC? But maybe it is indeed better > to have the same Makefile for different toolchain envronments. >=20 > -Dimitry >=20 >> On 02 Jan 2015, at 18:33, Warner Losh wrote: >>=20 >> This breaks building the kernel with clang 3.4.1 >>=20 >> Warner >>=20 >>=20 >>> On Jan 1, 2015, at 3:07 AM, Roman Divacky = wrote: >>>=20 >>> Author: rdivacky >>> Date: Thu Jan 1 10:07:57 2015 >>> New Revision: 276499 >>> URL: https://svnweb.freebsd.org/changeset/base/276499 >>>=20 >>> Log: >>> LLVM integrated assembler can assemble these files just fine. >>>=20 >>> Modified: >>> head/sys/conf/Makefile.amd64 >>> head/sys/conf/Makefile.i386 >>> head/sys/conf/Makefile.pc98 >>>=20 >>> Modified: head/sys/conf/Makefile.amd64 >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- head/sys/conf/Makefile.amd64 Thu Jan 1 09:33:46 2015 = (r276498) >>> +++ head/sys/conf/Makefile.amd64 Thu Jan 1 10:07:57 2015 = (r276499) >>> @@ -37,11 +37,6 @@ INCLUDES+=3D -I$S/contrib/libfdt >>> CFLAGS+=3D -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer >>> .endif >>>=20 >>> -# XXX: clang integrated-as doesn't grok .codeNN directives yet >>> -ASM_CFLAGS.acpi_wakecode.S=3D ${CLANG_NO_IAS} >>> -ASM_CFLAGS.mpboot.S=3D ${CLANG_NO_IAS} >>> -ASM_CFLAGS+=3D ${ASM_CFLAGS.${.IMPSRC:T}} >>> - >>> %BEFORE_DEPEND >>>=20 >>> %OBJS >>>=20 >>> Modified: head/sys/conf/Makefile.i386 >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- head/sys/conf/Makefile.i386 Thu Jan 1 09:33:46 2015 = (r276498) >>> +++ head/sys/conf/Makefile.i386 Thu Jan 1 10:07:57 2015 = (r276499) >>> @@ -32,11 +32,6 @@ S=3D ../../.. >>>=20 >>> INCLUDES+=3D -I$S/contrib/libfdt >>>=20 >>> -# XXX: clang integrated-as doesn't grok .codeNN directives yet >>> -ASM_CFLAGS.acpi_wakecode.S=3D ${CLANG_NO_IAS} >>> -ASM_CFLAGS.mpboot.s=3D ${CLANG_NO_IAS} >>> -ASM_CFLAGS+=3D ${ASM_CFLAGS.${.IMPSRC:T}} >>> - >>> %BEFORE_DEPEND >>>=20 >>> %OBJS >>>=20 >>> Modified: head/sys/conf/Makefile.pc98 >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- head/sys/conf/Makefile.pc98 Thu Jan 1 09:33:46 2015 = (r276498) >>> +++ head/sys/conf/Makefile.pc98 Thu Jan 1 10:07:57 2015 = (r276499) >>> @@ -30,10 +30,6 @@ S=3D ../../.. >>> .endif >>> .include "$S/conf/kern.pre.mk" >>>=20 >>> -# XXX: clang integrated-as doesn't grok .codeNN directives yet >>> -ASM_CFLAGS.mpboot.s=3D ${CLANG_NO_IAS} >>> -ASM_CFLAGS+=3D ${ASM_CFLAGS.${.IMPSRC:T}} >>> - >>> %BEFORE_DEPEND >>>=20 >>> %OBJS >>>=20 >>=20 >>=20 >=20 --Apple-Mail=_1BC221AF-D4D6-47E4-854A-8197EB7222B2 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJUp2yuAAoJEGwc0Sh9sBEAF0cQAJRRGeBLvyM+Qx7+fJtLe/VY vPINOav/cB/uXRpii+aEqrd9hOIfVnMKoPPRAtFwN2SIc4wQ0oECWiUXYor7mpya +PnScM/aJvTpA4QhkCP6eOBgUvD3U0E8ISAJj8lMqVMDW5HrlWPs89o2w0c4U1en QKK1rfUqb3opNoDZiF4HIvzRrH6pIk87ZqxMSF/lpQyuWoWdo3o3YYV0or3mxg6b hw3sAvz+Wl9yyOK+0EjifbBtoV5zAVH33gH/nyLWSLHfU0GoPZikO9Nb/EodfteW sUtF7B1O4P+/cwCJKHFCboAozE7JXYrbTfpuFCCT/gGbXmt+qEzgca5XQpI0RAyb /MxOlKpr2bLTebWmQeBGGod2Lp8TUcyNBRvKbk5VRGyiUxqthCg6iGFOGJX99W+G wJmyaSbSNADGyA169laeTA3bHkxfr9ojQl/bvIpr+5ND0Q/aLabA7Z5sHOX/zk3k 61EVyT+mn0nVqHHZ4LsOCk9y7xjPyf3yR6NsqKMZqXl8icAOWHSww5QNR7HvH3C9 FB4sViYn1iozkIH9sxumWrtQAO5gxiwKXZGjx/tDpQdYAds0SD6jabZqXjsfrM/N rxUPR7uD4/GvQNInU0B41UkCSzDNhQnXV2Jeo/xtrK1w2u8o9GCbFG4xUaNSzPH8 cNxhLQxL7vhzvmVIACA7 =G2kz -----END PGP SIGNATURE----- --Apple-Mail=_1BC221AF-D4D6-47E4-854A-8197EB7222B2--