Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 15 Nov 2018 23:03:13 +0100
From:      Tobias Kortkamp <tobik@FreeBSD.org>
To:        Jochen Neumeister <joneum@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r485048 - in head/databases: . pgpool-II-40
Message-ID:  <1542319393.56339.1578537352.30511AF8@webmail.messagingengine.com>
In-Reply-To: <201811152106.wAFL6RwE098338@repo.freebsd.org>
References:  <201811152106.wAFL6RwE098338@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 15, 2018, at 22:06, Jochen Neumeister wrote:
> Author: joneum
> Date: Thu Nov 15 21:06:26 2018
> New Revision: 485048
> URL: https://svnweb.freebsd.org/changeset/ports/485048
> 
> Log:
>   New Port: databases/pgpool-II-40
>   
>   pgpool is a connection pool server for PostgreSQL. pgpool runs between
>   PostgreSQL's clients(front ends) and servers(back ends). A PostgreSQL 
> client can
>   connect to pgpool as if it were a standard PostgreSQL server.
>   
>   pgpool caches the connection to PostgreSQL server to reduce the overhead to
>   establish the connection to it.
>   
>   WWW: http://pgpool.net/
>   
>   PR:		232957
>   Reported by:	Franco Ricci <franco.ricc@gmail.com>
>   Approved by:	tz (implicit)
>   Sponsored by:	Netzkommune GmbH
> 
> Added:
>   head/databases/pgpool-II-40/
>      - copied from r485040, head/databases/pgpool-II-37/
> Modified:
>   head/databases/Makefile
>   head/databases/pgpool-II-40/Makefile
>   head/databases/pgpool-II-40/distinfo
>   head/databases/pgpool-II-40/pkg-plist
> 
> Modified: head/databases/Makefile
> ==============================================================================
> --- head/databases/Makefile	Thu Nov 15 20:56:56 2018	(r485047)
> +++ head/databases/Makefile	Thu Nov 15 21:06:26 2018	(r485048)
> @@ -612,6 +612,7 @@
>      SUBDIR += pgpool-II-35
>      SUBDIR += pgpool-II-36
>      SUBDIR += pgpool-II-37
> +    SUBDIR += pgpool-II-40
>      SUBDIR += pgreplay
>      SUBDIR += pgroonga
>      SUBDIR += pgrouting
> 
> Modified: head/databases/pgpool-II-40/Makefile
> ==============================================================================
> --- head/databases/pgpool-II-37/Makefile	Thu Nov 15 19:08:47 2018	(r485040)
> +++ head/databases/pgpool-II-40/Makefile	Thu Nov 15 21:06:26 2018	(r485048)
> @@ -1,10 +1,10 @@
>  # $FreeBSD$
>  
>  PORTNAME=	pgpool-II
> -PORTVERSION=	3.7.5
> +PORTVERSION=	4.0.1
>  CATEGORIES=	databases
>  MASTER_SITES=	http://www.pgpool.net/mediawiki/images/
> -PKGNAMESUFFIX=	37
> +PKGNAMESUFFIX=	40
>  
>  MAINTAINER=	tz@FreeBSD.org
>  COMMENT=	Connection pool server for PostgreSQL
> @@ -12,10 +12,10 @@ COMMENT=	Connection pool server for PostgreSQL
>  LICENSE=	MIT
>  LICENSE_FILE=	${WRKSRC}/COPYING
>  
> -BROKEN_SSL=	openssl111
> -BROKEN_SSL_REASON_openssl111=	library 'ssl' is required for OpenSSL
> +BROKEN_SSL=	openssl-devel
> +BROKEN_SSL_REASON_openssl-devel=	library 'ssl' is required for OpenSSL

This part should be reverted.  It was ok before and openssl-devel
was removed, so BROKEN_SSL=openssl-devel has no effect.

> -PORTSCOUT=	limit:^3.7.[0-9]*
> +PORTSCOUT=	limit:^4.0.[0-9]*
>  
>  USES=		gmake libtool pgsql:9.6+
>  GNU_CONFIGURE=	yes
> @@ -26,11 +26,27 @@ CONFLICTS=	pgpool-II-[0-9]*
>  
>  PORTDOCS=	*
>  
> -OPTIONS_DEFINE=	DOCS SSL
> +PAM_DESC=	Build with PAM support
> +SSL_DESC=	Build with OpenSSL support
> +MEMCACHED_DESC =	Use memcached for in memory query cache
> +
> +OPTIONS_DEFINE=	DOCS SSL PAM MEMCACHED
>  OPTIONS_DEFAULT=	SSL
>  
>  SSL_CONFIGURE_WITH=	openssl
>  SSL_USES=		ssl
> +
> +.include <bsd.port.options.mk>
> +
> +.if ${PORT_OPTIONS:MPAM}
> +#CONFIGURE_ARGS+=	--with-pam
> +SSL_CONFIGURE_WITH=	pam
> +.endif

Hmm, was this supposed to be PAM_CONFIGURE_WITH ?

+.if ${PORT_OPTIONS:MMEMCACHED}
+CONFIGURE_ARGS+=--with-memcached=${LOCALBASE}/include
+LIB_DEPENDS+=	libmemcached.so:databases/libmemcached
+.endif

Why not use options helpers here too?



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1542319393.56339.1578537352.30511AF8>