From owner-p4-projects@FreeBSD.ORG Wed Jul 23 12:05:02 2003 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 51A1237B405; Wed, 23 Jul 2003 12:05:02 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F114237B404 for ; Wed, 23 Jul 2003 12:05:01 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 34CD643FB1 for ; Wed, 23 Jul 2003 12:05:01 -0700 (PDT) (envelope-from sam@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h6NJ510U020965 for ; Wed, 23 Jul 2003 12:05:01 -0700 (PDT) (envelope-from sam@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h6NJ50AM020952 for perforce@freebsd.org; Wed, 23 Jul 2003 12:05:00 -0700 (PDT) Date: Wed, 23 Jul 2003 12:05:00 -0700 (PDT) Message-Id: <200307231905.h6NJ50AM020952@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to sam@freebsd.org using -f From: Sam Leffler To: Perforce Change Reviews Subject: PERFORCE change 34890 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 19:05:03 -0000 http://perforce.freebsd.org/chv.cgi?CH=34890 Change 34890 by sam@sam_ebb on 2003/07/23 12:04:21 mark MPSAFE Affected files ... .. //depot/projects/netperf/sys/dev/fxp/if_fxp.c#2 edit Differences ... ==== //depot/projects/netperf/sys/dev/fxp/if_fxp.c#2 (text+ko) ==== @@ -811,11 +811,8 @@ /* * Hook our interrupt after all initialization is complete. - * XXX This driver has been tested with the INTR_MPSAFFE flag set - * however, ifp and its functions are not fully locked so MPSAFE - * should not be used unless you can handle potential data loss. */ - error = bus_setup_intr(dev, sc->irq, INTR_TYPE_NET /*|INTR_MPSAFE*/, + error = bus_setup_intr(dev, sc->irq, INTR_TYPE_NET | INTR_MPSAFE, fxp_intr, sc, &sc->ih); if (error) { device_printf(dev, "could not setup irq\n");