From nobody Sun Jun 22 07:18:55 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bQ2dD27jFz5yNCK; Sun, 22 Jun 2025 07:18:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bQ2dD1PLtz4894; Sun, 22 Jun 2025 07:18:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1750576736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lkyHJg0oPWAiu3CC9G/z+tCl4sCgQkLmM3Z99DXJ/KU=; b=mWZmWyw8e8S7S4hnAB/ysUpD32VwaUHNfLPgbdelyL416hqGvb9HQBvn7CeAqHBwNkd0eJ QaQM/oJv9aLeH7zeb14PDxiM+zBLNOuDvUwVjed1FVY0xogoUASAfgumw4+29AwWhv88U8 Jep5mdql9owao5MGJ57LaT/N9aQrGBQh1BphUNJB3C1DU18G4AA7RwE5oEFEtTUE9hODFo S1EeCRQ66zA1rmop0zh0axa9EFZafn4Ul/hOrpXt1YjoKDcxDtVogXIWx5GwmBQhO4lDlB Ot/9m1uQrIusKLXKEV5yIyW3NGbxlZKOxflH6cwmcgYkZpVAQncliXtHJ6CzQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1750576736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lkyHJg0oPWAiu3CC9G/z+tCl4sCgQkLmM3Z99DXJ/KU=; b=wS3e/uLnClz356q/fZKMYn4B86HTg0CK7S2LjrIQ4YsbQGXkYtH1e/tyN3pkc6fNHkw6rd hjX1SCuoPprJkUjlBSQMwsF2Xem/bhV08jwXaNhtdG3b16UkpAwA51OmCiIUXpCI1rjGQC 5CQlir9xRNC6BFQqyeIDruNl86Qt/JkeiDMIokOYtlAPibSGF4s1ALMHMuKMV3d5Cj2iWi Hh04ke6ruiA+5/JX9bgJPuKOHhFTtqBhTesEIfYqyzmvzi+6eJllZupWROCARkALTnpR31 T88SNeU0bQzLAmzFsoTsLqrAmNhUchm7JHaF2nMsAC8hCuc6Xfe/ikllH4wa4g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1750576736; a=rsa-sha256; cv=none; b=IP4WhB/pRirYG05ouAoJj4SkINsoWk3dpPIM4HmPxsaDWopwcru5PA+r0a1eGuhEoLhuIC ez/9bYTPlXlMKV2fFokpD2f+Qo952I9zyewxsrMOlDdZsKY5b9d5U23L7P5TUviCRiCP8F kA3uVtzrlPB79zB5cvj1R7XKbfB458sWus+Lsa55On/XwkAw0Vem5hw+8na+y/5xNL9dXm ceTXuI6Cx28vKbJFXYtJ0fxFnZXkmyG/a5/FqpbBBJpShmHmxpUNd1tmO068qM0Lvk6z70 hE52C2Qa3sx9l9ZNkBZIi0dX9TP7baGhswfqOJcH29Kvyf/nHkG/o/+MkP04ag== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bQ2dD0D0xz163L; Sun, 22 Jun 2025 07:18:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 55M7It1E016102; Sun, 22 Jun 2025 07:18:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 55M7Itdu016099; Sun, 22 Jun 2025 07:18:55 GMT (envelope-from git) Date: Sun, 22 Jun 2025 07:18:55 GMT Message-Id: <202506220718.55M7Itdu016099@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 33f65f12eba1 - stable/14 - bnxt: Fix BASE-T, 40G AOC, 1G-CX, autoneg and unknown media lists List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 33f65f12eba10588827a13d232337616f6f4facf Auto-Submitted: auto-generated The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=33f65f12eba10588827a13d232337616f6f4facf commit 33f65f12eba10588827a13d232337616f6f4facf Author: Kevin Bowling AuthorDate: 2025-06-14 23:46:05 +0000 Commit: Kevin Bowling CommitDate: 2025-06-22 07:18:41 +0000 bnxt: Fix BASE-T, 40G AOC, 1G-CX, autoneg and unknown media lists This was broken in c63d67e137f3, the early returns prevent building the media lists as expected. The BASE-T parts of the patch were suggested by "cyric@mm.st", while I am adding the additional 40G AOC, 1CX, autoneg and unknown PHY fixes based on code inspection. There may be additional work left here for Broadcom but this is certainly better than the returns. PR: 287395 Reported by: mickael.maillot@gmail.com, cyric@mm.st Tested by: Einar Bjarni Halldórsson (cherry picked from commit 5e6e4f752833acc96f1efc893318d3f6b74b9689) --- sys/dev/bnxt/bnxt_en/if_bnxt.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/sys/dev/bnxt/bnxt_en/if_bnxt.c b/sys/dev/bnxt/bnxt_en/if_bnxt.c index eea956759e9e..169255c9433e 100644 --- a/sys/dev/bnxt/bnxt_en/if_bnxt.c +++ b/sys/dev/bnxt/bnxt_en/if_bnxt.c @@ -4609,34 +4609,34 @@ bnxt_add_media_types(struct bnxt_softc *softc) case HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_40G_ACTIVE_CABLE: media_type = BNXT_MEDIA_AC; - return; + break; case HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_1G_BASECX: media_type = BNXT_MEDIA_BASECX; - return; + break; case HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_1G_BASET: case HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_BASET: case HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_BASETE: media_type = BNXT_MEDIA_BASET; - return; + break; case HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_BASEKX: media_type = BNXT_MEDIA_BASEKX; - return; + break; case HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_SGMIIEXTPHY: media_type = BNXT_MEDIA_BASESGMII; - return; + break; case HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_UNKNOWN: /* Only Autoneg is supported for TYPE_UNKNOWN */ - return; + break; default: /* Only Autoneg is supported for new phy type values */ device_printf(softc->dev, "phy type %d not supported by driver\n", phy_type); - return; + break; } switch (link_info->sig_mode) {