From owner-svn-src-all@FreeBSD.ORG  Mon Jul 13 21:43:35 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 75439106564A;
	Mon, 13 Jul 2009 21:43:35 +0000 (UTC)
	(envelope-from lstewart@freebsd.org)
Received: from lauren.room52.net (lauren.room52.net [210.50.193.198])
	by mx1.freebsd.org (Postfix) with ESMTP id 03A3E8FC0A;
	Mon, 13 Jul 2009 21:43:34 +0000 (UTC)
	(envelope-from lstewart@freebsd.org)
Received: from lstewart-laptop.caia.swin.edu.au
	(host86-150-124-14.range86-150.btcentralplus.com [86.150.124.14])
	(authenticated bits=0)
	by lauren.room52.net (8.14.3/8.14.3) with ESMTP id n6DLM3wZ051224
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Tue, 14 Jul 2009 07:22:09 +1000 (EST)
	(envelope-from lstewart@freebsd.org)
Message-ID: <4A5BA56A.8000208@freebsd.org>
Date: Mon, 13 Jul 2009 22:21:46 +0100
From: Lawrence Stewart <lstewart@freebsd.org>
User-Agent: Thunderbird 2.0.0.22 (X11/20090626)
MIME-Version: 1.0
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org, np@freebsd.org
References: <200907131151.n6DBp35J024156@svn.freebsd.org>
	<20090713203416.GA2976@hub.freebsd.org>
In-Reply-To: <20090713203416.GA2976@hub.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=0.6 required=5.0 tests=AWL,BAYES_40,RCVD_IN_PBL,
	RDNS_DYNAMIC,SPF_SOFTFAIL autolearn=disabled version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on lauren.room52.net
Cc: 
Subject: Re: svn commit: r195654 - in head: . sys/dev/cxgb/ulp/tom
 sys/netinet sys/sys
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jul 2009 21:43:35 -0000

Navdeep Parhar wrote:
[snip]
> 
> Hello Lawrence,
> 
> 'to' should be renamed to 'toeo' in syncache_expand_establish_req() before the
> changes you made to cxgb_cpl_io.c will even compile.
> 
> -	struct toeopt to;
> +	struct toeopt toeo;

Oh dear, mea culpa.

> 
> Unfortunately, cxgb's TOM is commented out of the build system (ever since
> ARPv2) and so buildkernel won't catch stuff like this.  I have a tree that
> builds TOM with the latest head but it won't be ready+tested in time for 8.0.

That would explain why I missed this :(

Will get it fixed right away.

Cheers,
Lawrence