From owner-freebsd-arch  Sat Oct 26 15: 5: 0 2002
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 86DE437B401
	for <arch@freebsd.org>; Sat, 26 Oct 2002 15:04:59 -0700 (PDT)
Received: from rootlabs.com (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 3487A43E8A
	for <arch@freebsd.org>; Sat, 26 Oct 2002 15:04:59 -0700 (PDT)
	(envelope-from nate@rootlabs.com)
Received: (qmail 78687 invoked by uid 1000); 26 Oct 2002 22:05:00 -0000
Date: Sat, 26 Oct 2002 15:05:00 -0700 (PDT)
From: Nate Lawson <nate@root.org>
To: "M. Warner Losh" <imp@bsdimp.com>
Cc: arch@freebsd.org
Subject: Re: NO_WERROR and the kernel
In-Reply-To: <20021026.111312.21077495.imp@bsdimp.com>
Message-ID: <Pine.BSF.4.21.0210261503220.78632-100000@root.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-arch@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-arch.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-arch>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-arch>
X-Loop: FreeBSD.ORG

On Sat, 26 Oct 2002, M. Warner Losh wrote:
> Is there a reason that NO_WERROR doesn't work with the kernel?  Would
> there be a reason not to include the following patch?
> 
> Warner
> 
> Index: kern.pre.mk
> ===================================================================
> RCS file: /cache/ncvs/src/sys/conf/kern.pre.mk,v
> retrieving revision 1.19
> diff -u -r1.19 kern.pre.mk
> --- kern.pre.mk	17 Sep 2002 09:07:06 -0000	1.19
> +++ kern.pre.mk	26 Oct 2002 17:11:51 -0000
> @@ -48,7 +48,11 @@
>  .endif
>  .endif
>  DEFINED_PROF=	${PROF}
> +.if !defined(NO_WERROR)
>  WERROR?=	-Werror
> +.else
> +WERROR?=
> +.endif
>  
>  # Put configuration-specific C flags last (except for ${PROF}) so that they
>  # can override the others.

It used to be in there and was yanked on purpose (memory says phk but may
be wrong).  The idea is that too many were running with NO_WERROR=yes
(especially since that was the recommended way of doing things for so
long) and the only way to get things in shape was to remove it.  You can
get around it anyway when things are broken by doing WERROR= in
/etc/make.conf

-Nate


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message