From owner-dev-commits-doc-all@freebsd.org Thu Feb 11 19:23:46 2021 Return-Path: Delivered-To: dev-commits-doc-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 70A33532A70 for ; Thu, 11 Feb 2021 19:23:46 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dc64L2lW4z4hPY; Thu, 11 Feb 2021 19:23:46 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (unknown [IPv6:2601:648:8681:1cb0:6deb:8edd:e2d1:517c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 9455F29A5A; Thu, 11 Feb 2021 19:23:45 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: git: 5476df45eb - main - 13.0R/relnotes: Add entries for changes that happened in bhyve. To: Daniel Ebdrup Jensen , doc-committers@FreeBSD.org, dev-commits-doc-all@FreeBSD.org References: <202102110419.11B4J64X034699@gitrepo.freebsd.org> From: John Baldwin Message-ID: <4cf5028f-df8e-f910-b768-27ad49398da5@FreeBSD.org> Date: Thu, 11 Feb 2021 11:23:44 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <202102110419.11B4J64X034699@gitrepo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dev-commits-doc-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the doc repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Feb 2021 19:23:46 -0000 On 2/10/21 8:19 PM, Daniel Ebdrup Jensen wrote: > The branch main has been updated by debdrup: > > URL: https://cgit.FreeBSD.org/doc/commit/?id=5476df45eb064fc3bdd7172ce9f38822eb143307 > > commit 5476df45eb064fc3bdd7172ce9f38822eb143307 > Author: Daniel Ebdrup Jensen > AuthorDate: 2021-02-10 04:32:24 +0000 > Commit: Daniel Ebdrup Jensen > CommitDate: 2021-02-11 04:18:46 +0000 > > 13.0R/relnotes: Add entries for changes that happened in bhyve. > > While here, implement a template for cgit links called 'commit' for lack > of a better term. > > This fixes the only build issue with this patch, and has been tested in > Firefox with the run target as well. Hmm, can you make 'commit' configurable so it doesn't hardcode the src repository? E.g. can it take an optional 2nd arg (which defaults to 'src') which is the repo? I think it would also be good if it was 'githash' or the like as that's a bit more future proof should we have to change to something else in the future. (The old XML shortcut for this was named githash for precisely that reason.) It might also be nice if we could provide the full hash and centralize the abbreviation logic in the keyword so that if we eventually have to expand the prefix as our history grows we can fix that in one place and rebuild the docs without having to go fix all the actual places that use the keyword. -- John Baldwin