From owner-freebsd-ports Mon Jun 3 7:43: 3 2002 Delivered-To: freebsd-ports@freebsd.org Received: from mail.vinita.lt (mail.vinita.lt [217.147.34.8]) by hub.freebsd.org (Postfix) with ESMTP id 7F7CE37B401; Mon, 3 Jun 2002 07:42:53 -0700 (PDT) Received: from ctv-217-147-36-211.vinita.lt ([217.147.36.211] helo=rolnas.takas.lt) by mail.vinita.lt with esmtp (Exim 3.33 #1 (Debian)) id 17Et3w-0007ks-00; Mon, 03 Jun 2002 16:44:00 +0200 Received: from rolnas.takas.lt (localhost [127.0.0.1]) by rolnas.takas.lt (8.12.3/8.12.3) with ESMTP id g53Efuhv083831; Mon, 3 Jun 2002 16:41:56 +0200 (EET) (envelope-from rolnas@takas.lt) Received: (from rolnas@localhost) by rolnas.takas.lt (8.12.3/8.12.3/Submit) id g53EfocB083830; Mon, 3 Jun 2002 16:41:50 +0200 (EET) X-Authentication-Warning: rolnas.takas.lt: rolnas set sender to rolnas@takas.lt using -f Date: Mon, 3 Jun 2002 16:41:50 +0200 From: Rolandas Naujikas To: Jens Rehsack , dwcjr@FreeBSD.org Cc: ports@FreeBSD.org Subject: ports/net/{samba,samba-tng} doesn't batch {fetch,checksum} cleanly Message-ID: <20020603144150.GA83798@rolnas> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="ReaqsoxgOBHFXBhH" Content-Disposition: inline User-Agent: Mutt/1.3.99i Organization: VU MIF Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org --ReaqsoxgOBHFXBhH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline After last commit, the situation is: ---------------------------------------------------------------- [rolnas@rolnas /usr/ports/net/samba]$ make -DBATCH fetch /usr/ports/net/samba/scripts/configure.samba: cannot create /usr/tmp/usr/ports/net/samba/Makefile.inc: directory nonexistent *** Error code 2 Stop in /usr/ports/net/samba. ---------------------------------------------------------------- The solution possible is to look in www/mod_php4/scripts/configure.php to put ${MKDIR} ${WRKDIRPREFIX}${REALCURDIR} before creating ${WRKDIRPREFIX}${REALCURDIR}/Makefile.inc The other problem is checklist.* files left around with -DBATCH (same problem in www/mod_php4/scripts/configure.php). The solution to do not use temporary file to read selected options and use backtips. The patch are below. Rolandas --ReaqsoxgOBHFXBhH Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=patch-configure --- configure.samba.orig Wed May 29 15:21:11 2002 +++ configure.samba Wed May 29 17:04:31 2002 @@ -4,14 +4,12 @@ exit fi -tempfile=`/usr/bin/mktemp -t checklist` - if [ "${BATCH}" ]; then if [ "${SAMBA_OPTIONS}" ]; then set ${SAMBA_OPTIONS} fi else - /usr/bin/dialog --title "configuration options" --clear \ + options=`/usr/bin/dialog --title "configuration options" --clear \ --checklist "\n\ Please select desired options:" -1 -1 9 \ syslog "With syslog support" OFF \ @@ -22,14 +20,13 @@ utmp "With UTMP support" OFF \ msdfs "With MSDFS support" OFF \ quota "With Quota support" OFF \ -2> $tempfile +2>&1 1>/dev/tty` retval=$? - if [ -s $tempfile ]; then - set `cat $tempfile` + if [ -n "$options" ]; then + set $options fi - rm -f $tempfile case $retval in 0) if [ -z "$*" ]; then @@ -42,6 +39,7 @@ esac fi +${MKDIR} ${WRKDIRPREFIX}${REALCURDIR} echo "SCRIPT_RUN=yes" >${WRKDIRPREFIX}${REALCURDIR}/Makefile.inc while [ "$1" ]; do --ReaqsoxgOBHFXBhH-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message