From owner-freebsd-rc@FreeBSD.ORG  Fri Mar 15 12:11:27 2013
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
Delivered-To: freebsd-rc@FreeBSD.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 1D065779;
 Fri, 15 Mar 2013 12:11:27 +0000 (UTC) (envelope-from jilles@stack.nl)
Received: from mx1.stack.nl (unknown [IPv6:2001:610:1108:5012::107])
 by mx1.freebsd.org (Postfix) with ESMTP id DDE8EA47;
 Fri, 15 Mar 2013 12:11:26 +0000 (UTC)
Received: from snail.stack.nl (snail.stack.nl [IPv6:2001:610:1108:5010::131])
 by mx1.stack.nl (Postfix) with ESMTP id 2AEC81203E5;
 Fri, 15 Mar 2013 13:11:12 +0100 (CET)
Received: by snail.stack.nl (Postfix, from userid 1677)
 id 0721E2848C; Fri, 15 Mar 2013 13:11:12 +0100 (CET)
Date: Fri, 15 Mar 2013 13:11:11 +0100
From: Jilles Tjoelker <jilles@stack.nl>
To: Olivier Smedts <olivier@gid0.org>
Subject: Re: conf/174595: /etc/rc.d/sysctl : unknown oid &#39; XXX&#39;
 [regression]
Message-ID: <20130315121111.GA10115@stack.nl>
References: <201303130920.r2D9K0xI078987@freefall.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201303130920.r2D9K0xI078987@freefall.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: freebsd-rc@FreeBSD.org
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Discussion related to /etc/rc.d design and implementation."
 <freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-rc>,
 <mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
 <mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Mar 2013 12:11:27 -0000

On Wed, Mar 13, 2013 at 09:20:00AM +0000, Olivier Smedts wrote:
> The following reply was made to PR conf/174595; it has been noted by GNATS.

> From: Olivier Smedts <olivier@gid0.org>
> To: bug-followup@FreeBSD.org, olivier@gid0.org
> Cc: delphij@freebsd.org
> Subject: Re: conf/174595: /etc/rc.d/sysctl : unknown oid &#39;XXX&#39; [regression]
> Date: Wed, 13 Mar 2013 10:11:08 +0100

>  Isn't the logic inverted between the start/reload case and the
>  lastload case ?

>  The attached patch seems logical :
>  - tell sysctl to ignore unknown OIDs during the "start" case (corrects
>  the regression)
>  rationale : some klds still aren't loaded at start, my example with
>  linux_enable="YES" in rc.conf and compat.linux.osrelease=2.6.32 in
>  sysctl.conf is a common use case, and it's not meaningful / it's
>  confusing to show a startup error about a sysctl which couldn't be set
>  while it actually has been set in lastload stage
>  - tell sysctl to not ignore unknown OIDs during the "lastload" case
>  (preserve added value of r244198)
>  rationale : if an OID is really unknown and couldn't be set neither in
>  the start nor in the lastload cases, it's useful to be told about the
>  fatal error
>  - behave in the "reload" case like in the "lastload" stage
>  rationale : reloads usually happen after system startup so they're
>  really a "lastlastload", and it's useful to spit out errors about
>  unknown OIDs to the operator who asked for a reload

I think the patch is how it should be.

>  Hoping the attachment won't be stripped,

GNATS mangled the patch while forwarding the email (by indenting the
MIME structure and removing the MIME headers) but shows it correctly in
the PR.

-- 
Jilles Tjoelker