From owner-svn-src-all@freebsd.org Fri Apr 19 18:34:13 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 335A21575277; Fri, 19 Apr 2019 18:34:13 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id ADA3C8C06B; Fri, 19 Apr 2019 18:34:12 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf1-x444.google.com with SMTP id h5so2901049pfo.0; Fri, 19 Apr 2019 11:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=IiR/cve4fomaxs81NIJVeW1YfCiYPHkUKWOkNdQsIL4=; b=LUPqoSeVim7kJs0tznW3XkhbGPIHDDEDavDoz0uCgvE8aYMnpZ2cyp+5lvazrDfxe+ I+eFI+sN9elVuNAhO9oxvkEvxV3n1dFDJfvRZk/viJyxSqs3PfM4A1/YwngEmRCliBy5 EA+7+PNE/tgXaWSpdIxqsh5pORhRme9V0l3SwW9AK4LifToD3y1m7narFeJ/N5VkodgT jS4DthauB7Bs0rk1MNDBmyeG8u9LFIiKoqn9U5IuzGF1i4Ycv2Hhle1VYYsFZFpiPyTG /cvMId22S72Z7rRJz/K7MuPk0D8n6hJv2o31CSayfJYj79+FR73/ckpuP1kN9u3C++rp CF8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=IiR/cve4fomaxs81NIJVeW1YfCiYPHkUKWOkNdQsIL4=; b=lSonsJwY5nBaBqtJBhjd2TyePsCe2SqP72SgCJ4w91/ICeRQy183vEK2i6o3k98TNV TPplW3o+KkrzIbBrhDn5DVckjPBoY4Y/Nqub14k5p/AZUhc9+TDpa3+NKHCBZA30hyUe u8WxMNAUmiHL9h01uFqv5dCm2FwV7m21+HDCmm+wtY4Kth9FwIXjsOws7T4cK7e+k3YO FKoNHIGTfX83pkoI/L1Kyihfflo8nJwEYerExViImNmMK3suF46CtAx5oqPSGOJgOP0B 4PxrdixTptJYil402Cg126tX1ILi1B7JN22h5DWJ+FWGnWcpjWC8RViqb1GK6kViZM9E TS0Q== X-Gm-Message-State: APjAAAXzQsQrlJk/e8f/maha8gbpFxcZpUAH40e/tviH7pwVQRIwYvru t+LPPt5+1n8ajY/5lDOvNCLzQhEouho= X-Google-Smtp-Source: APXvYqzxDoxJozIbv6AU0IpG4HyaHRp65II0xIVhbToTTcMcnap/BqXOf7NW49vUrFjmfgk/yo8xJw== X-Received: by 2002:a63:28f:: with SMTP id 137mr5356941pgc.377.1555698851406; Fri, 19 Apr 2019 11:34:11 -0700 (PDT) Received: from [192.168.20.22] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id h8sm2722108pgd.42.2019.04.19.11.34.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Apr 2019 11:34:10 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r346390 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs From: Enji Cooper X-Mailer: iPhone Mail (16E227) In-Reply-To: <8d763a63-0915-d9f6-1b90-5e902f06ebe4@FreeBSD.org> Date: Fri, 19 Apr 2019 11:34:10 -0700 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201904191544.x3JFijLe075969@repo.freebsd.org> <0F708A9C-D29D-466A-B541-06DB7127349E@gmail.com> <8d763a63-0915-d9f6-1b90-5e902f06ebe4@FreeBSD.org> To: Alexander Motin X-Rspamd-Queue-Id: ADA3C8C06B X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.94)[-0.936,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Apr 2019 18:34:13 -0000 > On Apr 19, 2019, at 11:29, Alexander Motin wrote: >=20 > On 19.04.2019 14:09, Enji Cooper wrote: >>> On Apr 19, 2019, at 08:44, Alexander Motin wrote: >>>=20 >>> Author: mav >>> Date: Fri Apr 19 15:44:45 2019 >>> New Revision: 346390 >>> URL: https://svnweb.freebsd.org/changeset/base/346390 >>>=20 >>> Log: >>> Change the way FreeBSD GID inheritance is hacked. >>>=20 >>> I believe previous ifdef caused NULL dereference in later zfs_log_create= () >>> on attempt to create file inside directory belonging to ephemeral group >>> created on illumos, trying to write to log information about GID domain >>> of the newly created file, inheriting the ephemeral GID. >>>=20 >>> This patch reuses original illumos SGID code with exception that due to >>> lack of ID mapping code on FreeBSD ephemeral GID will turn into GID_NOBO= DY >>> by another ifdef inside zfs_fuid_map_id(). >>=20 >> Hi mav@! >> I was wondering, does this break ACL mappings with sticky bits for the= group ID (or was it broken to begin with)? If the latter, does it make sens= e to file a bug/add a TODO comment? >=20 > I don't believe this change should have any visible results for native > FreeBSD pools. It does change change handling of some pools coming from > illumos, but previous behavior in that case resulted in kernel panic, so > anything else is better, while full compatibility is impossible, since > FreeBSD has no kernel-side AD UID/GID mapping, used by illumos SMB. >=20 > Could you better describe what ACL mapping breakage you are talking about?= Ah... Yeah, it makes sense to leave this alone since it=E2=80=99s a miss= ing ZFS on FreeBSD feature. Thank you! -Enji PS I was likely messing up my interpretation of the stat field. I didn=E2=80= =99t read the manpage yet.=