From owner-freebsd-bugs@FreeBSD.ORG Mon Jul 29 07:20:01 2013 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id DE1D8D3D for ; Mon, 29 Jul 2013 07:20:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id BCC132258 for ; Mon, 29 Jul 2013 07:20:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r6T7K0Am008408 for ; Mon, 29 Jul 2013 07:20:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r6T7K007008407; Mon, 29 Jul 2013 07:20:00 GMT (envelope-from gnats) Resent-Date: Mon, 29 Jul 2013 07:20:00 GMT Resent-Message-Id: <201307290720.r6T7K007008407@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Thomas Schweikle Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id F1C29CBE for ; Mon, 29 Jul 2013 07:15:28 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id DF28A222C for ; Mon, 29 Jul 2013 07:15:28 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r6T7FSk4083815 for ; Mon, 29 Jul 2013 07:15:28 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r6T7FS8H083814; Mon, 29 Jul 2013 07:15:28 GMT (envelope-from nobody) Message-Id: <201307290715.r6T7FS8H083814@oldred.freebsd.org> Date: Mon, 29 Jul 2013 07:15:28 GMT From: Thomas Schweikle To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: misc/180920: open-vm-tools-nox11 does not compile because of unsigned signed compares X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jul 2013 07:20:01 -0000 >Number: 180920 >Category: misc >Synopsis: open-vm-tools-nox11 does not compile because of unsigned signed compares >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jul 29 07:20:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Thomas Schweikle >Release: FreeBSD 10.0-CURRENT >Organization: n.a. >Environment: FreeBSD test-tps-fbsdc-muc.bfs.de 10.0-CURRENT FreeBSD 10.0-CURRENT #10: Fri Jul 26 18:22:07 CEST 2013 root@test-tps-fbsdc-muc.bfs.de:/usr/obj/usr/src/sys/TEST-TPS-FBSDC-MUC amd64 >Description: hgfsServer.c:3560:19: error: comparison of unsigned expression < 0 is always false [-Werror,-Wtautological-compare] if (pathLength < 0 || pathLength >= sizeof p.mountPoint) { ~~~~~~~~~~ ^ ~ hgfsServer.c:4559:30: error: comparison of constant 255 with expression of type 'HgfsOp' is always false [-Werror,-Wtautological-constant-out-of-range-compare] if (HGFS_V4_LEGACY_OPCODE == request->op) { ~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~ 2 errors generated. *** Error code 1 Stop. make: stopped in /usr/ports/emulators/open-vm-tools-nox11/work/open-vm-tools-8.6.0-425873/lib/hgfsServer *** Error code 1 Stop. make: stopped in /usr/ports/emulators/open-vm-tools-nox11/work/open-vm-tools-8.6.0-425873/lib *** Error code 1 Stop. make: stopped in /usr/ports/emulators/open-vm-tools-nox11/work/open-vm-tools-8.6.0-425873 *** Error code 1 Stop. make: stopped in /usr/ports/emulators/open-vm-tools-nox11 >How-To-Repeat: On all active FreeBSD versions (8,9, CURRENT): go to /usr/ports/emulators/open-vm-tools-nox11, then execute "make clean build". Build step will fail due to the above compiler error. >Fix: >Release-Note: >Audit-Trail: >Unformatted: