Date: Mon, 6 Mar 2000 17:24:54 -0800 (PST) From: odip@bionet.nsc.ru To: freebsd-gnats-submit@FreeBSD.org Subject: ports/17237: in samba suite smbclient -M worked incorrectly on non english codepages [patch] Message-ID: <200003070124.RAA00753@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 17237
>Category: ports
>Synopsis: in samba suite smbclient -M worked incorrectly on non english codepages [patch]
>Confidential: no
>Severity: serious
>Priority: high
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Mar 6 17:30:01 PST 2000
>Closed-Date:
>Last-Modified:
>Originator: Dmitry Grigorovich
>Release: 3.4-RELEASE
>Organization:
ICiG
>Environment:
FreeBSD comp1.bionet.nsc.ru 3.4-RELEASE FreeBSD 3.4-RELEASE #0: Tue Mar 7 05:21
:38 NOVT 2000 root@comp1.bionet.nsc.ru:/usr/src/sys/compile/ODIP i386
>Description:
When using samba suite
my locale on UNIX is ru_RU.KOI8-R and locale on Windows is cp1251
In smb.conf all locales correctly specified
When I send message in cyrrilic via "smbclient -M name"
then it incorrectly appear on my WindowNT in strange codepage !
Explanation:
Text saved to buffer on UNIX,
but not translated to Windows codepage
and sended in UNIX codepage to Windows machine !!!
>How-To-Repeat:
When you codepage on UNIX is not same,
such as on Windows machine just send message to windows machine:
"smbclient -M name"
and type any non english characters,
e.g. cyrillic letters
>Fix:
--- client/client.c.orig Thu Nov 11 08:35:59 1999
+++ client/client.c Tue Mar 7 05:59:04 2000
@@ -194,6 +194,10 @@
msg[l++] = '\r';
msg[l] = c;
}
+ msg[l]= '\0';
+
+ /* input language code to internal one */
+ CNV_INPUT(msg);
if (!cli_message_text(cli, msg, l, grp_id)) {
printf("SMBsendtxt failed (%s)\n",cli_errstr(cli));
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200003070124.RAA00753>