From owner-svn-src-all@freebsd.org Fri Mar 11 09:50:09 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8CC76ACC4C8; Fri, 11 Mar 2016 09:50:09 +0000 (UTC) (envelope-from des@des.no) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id 53DB51CF8; Fri, 11 Mar 2016 09:50:09 +0000 (UTC) (envelope-from des@des.no) Received: from desk.des.no (smtp.des.no [194.63.250.102]) by smtp.des.no (Postfix) with ESMTP id 769144C35; Fri, 11 Mar 2016 09:50:08 +0000 (UTC) Received: by desk.des.no (Postfix, from userid 1001) id 09C473AF44; Fri, 11 Mar 2016 10:50:08 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Ed Maste Cc: "src-committers\@freebsd.org" , "svn-src-all\@freebsd.org" , "svn-src-head\@freebsd.org" Subject: Re: svn commit: r296633 - in head: crypto/openssh crypto/openssh/contrib crypto/openssh/contrib/redhat crypto/openssh/contrib/suse crypto/openssh/openbsd-compat crypto/openssh/regress crypto/openssh/re... References: <201603110015.u2B0FT5v065136@repo.freebsd.org> Date: Fri, 11 Mar 2016 10:50:08 +0100 In-Reply-To: (Ed Maste's message of "Fri, 11 Mar 2016 03:05:32 +0000") Message-ID: <867fh9cpin.fsf@desk.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2016 09:50:09 -0000 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ed Maste writes: > It looks like this broke mips: > > In file included from > /scratch/tmp/emaste/freebsd/lib/libpam/modules/pam_ssh/../../../../crypto= /openssh/key.h:29, > from > /scratch/tmp/emaste/freebsd/lib/libpam/modules/pam_ssh/pam_ssh.c:60: > /scratch/tmp/emaste/freebsd/lib/libpam/modules/pam_ssh/../../../../crypto= /openssh/sshkey.h:145: > warning: '__bounded__' attribute directive ignored Please try the attached patch. I don't know if it fixes the issue, but it's a good idea either way. I'm trying to find out why gcc complains about this specific instance of __bounded__ but not about any of the 88 others in OpenSSH; the only lead I have so far is that pam_ssh uses a different WARNS level. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=pam-ssh-warns.diff Index: lib/libpam/modules/pam_ssh/Makefile =================================================================== --- lib/libpam/modules/pam_ssh/Makefile (revision 296634) +++ lib/libpam/modules/pam_ssh/Makefile (working copy) @@ -7,7 +7,6 @@ MAN= pam_ssh.8 SRCS= pam_ssh.c -WARNS?= 3 CFLAGS+= -I${SSHDIR} -include ssh_namespace.h SRCS+= ssh_namespace.h Index: lib/libpam/modules/pam_ssh/pam_ssh.c =================================================================== --- lib/libpam/modules/pam_ssh/pam_ssh.c (revision 296634) +++ lib/libpam/modules/pam_ssh/pam_ssh.c (working copy) @@ -84,7 +84,9 @@ }; static const char *pam_ssh_agent = "/usr/bin/ssh-agent"; -static char *const pam_ssh_agent_argv[] = { "ssh_agent", "-s", NULL }; +static char str_ssh_agent[] = "ssh-agent"; +static char str_dash_s[] = "-s"; +static char *const pam_ssh_agent_argv[] = { str_ssh_agent, str_dash_s, NULL }; static char *const pam_ssh_agent_envp[] = { NULL }; /* --=-=-=--