From owner-svn-src-all@FreeBSD.ORG Thu Jun 18 21:08:31 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C90A8106564A; Thu, 18 Jun 2009 21:08:31 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68]) by mx1.freebsd.org (Postfix) with ESMTP id 48AE58FC1F; Thu, 18 Jun 2009 21:08:30 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from localhost (localhost [127.0.0.1]) by woozle.rinet.ru (8.14.3/8.14.3) with ESMTP id n5IL8Twp091304; Fri, 19 Jun 2009 01:08:29 +0400 (MSD) (envelope-from marck@rinet.ru) Date: Fri, 19 Jun 2009 01:08:29 +0400 (MSD) From: Dmitry Morozovsky To: =?ISO-8859-15?Q?Dag-Erling_Sm=F8rgrav?= In-Reply-To: <86eith5k7h.fsf@ds4.des.no> Message-ID: References: <200906171731.n5HHVktG082752@svn.freebsd.org> <86iqit5sms.fsf@ds4.des.no> <200906181455.26797.jhb@freebsd.org> <86eith5k7h.fsf@ds4.des.no> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) X-NCC-RegID: ru.rinet X-OpenPGP-Key-ID: 6B691B03 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (woozle.rinet.ru [0.0.0.0]); Fri, 19 Jun 2009 01:08:29 +0400 (MSD) Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-7@freebsd.org, John Baldwin Subject: Re: svn commit: r194377 - stable/7/sys/dev/ath/ath_hal X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2009 21:08:32 -0000 On Thu, 18 Jun 2009, Dag-Erling Sm?rgrav wrote: DS> > I think Dmitry means more that all the prop changes stuff clutters the actual DS> > commit messages. I would like to see them removed from the subject line at DS> > least so that the subject line clearly shows where real changes are being DS> > made. DS> DS> That's reasonable - but I would still very much like to see prop changes DS> in the commit email. It's not just svn:mergeinfo, there have also been DS> cases of incorrect svn:keywords, and even someone who set svn:mime-type DS> to application/octet-stream on a couple of files because they couldn't DS> figure out the correct svn:keywords syntax. DS> DS> BTW, if you do as Dmitry suggests, how will you handle props-only DS> commits like r192599, r192646 or r192653? As for last question: there are _only_ props changes lines in the changes list. This can be treated as a stop-case for changing subject at all (also, these cases are rather rare comparing to normal development/merging) -- Sincerely, D.Marck [DM5020, MCK-RIPE, DM3-RIPN] [ FreeBSD committer: marck@FreeBSD.org ] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** ------------------------------------------------------------------------