From owner-cvs-src@FreeBSD.ORG  Wed Oct 15 05:44:17 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0799C16A4B3; Wed, 15 Oct 2003 05:44:17 -0700 (PDT)
Received: from newtrinity.zeist.de (newtrinity.zeist.de [217.24.217.8])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id BAE7443FAF; Wed, 15 Oct 2003 05:44:15 -0700 (PDT)
	(envelope-from marius@newtrinity.zeist.de)
Received: from newtrinity.zeist.de (localhost [127.0.0.1])
	h9FCi7nU080566;	Wed, 15 Oct 2003 14:44:07 +0200 (CEST)
	(envelope-from marius@newtrinity.zeist.de)
Received: (from marius@localhost)
	by newtrinity.zeist.de (8.12.10/8.12.10/Submit) id h9FCi1gf080565;
	Wed, 15 Oct 2003 14:44:01 +0200 (CEST)
	(envelope-from marius)
Date: Wed, 15 Oct 2003 14:44:01 +0200
From: Marius Strobl <marius@alchemy.franken.de>
To: Alan Cox <alc@cs.rice.edu>
Message-ID: <20031015144401.I40718@newtrinity.zeist.de>
References: <200310150800.h9F80j13045191@repoman.freebsd.org>
	<20031015084043.GR27527@cs.rice.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <20031015084043.GR27527@cs.rice.edu>;
	from alc@cs.rice.edu on Wed, Oct 15, 2003 at 03:40:43AM -0500
X-AntiVirus: checked by AntiVir Milter 1.0.6; AVE 6.22.0.1; VDF 6.22.0.6
cc: Bruce M Simpson <bms@spc.org>
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
cc: cvs-src@freebsd.org
Subject: Re: cvs commit: src/sys/vm vm_fault.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Oct 2003 12:44:17 -0000

On Wed, Oct 15, 2003 at 03:40:43AM -0500, Alan Cox wrote:
> On Wed, Oct 15, 2003 at 01:00:45AM -0700, Alan Cox wrote:
> > alc         2003/10/15 01:00:45 PDT
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/vm               vm_fault.c 
> >   Log:
> >    - vm_fault_copy_entry() should not assume that the source object contains
> >      every page.  If the source entry was read-only, one or more wired pages
> >      could be in backing objects.
> >    - vm_fault_copy_entry() should not set the PG_WRITEABLE flag on the page
> >      unless the destination entry is, in fact, writeable.
> >   
> >   Revision  Changes    Path
> >   1.181     +19 -5     src/sys/vm/vm_fault.c
> 
> This fixes the problem with mlockall() and cdrecord.
> 

What was the general usability of mlockall() before this commit? I was
told about at least two other programs that triggered a panic when using
mlockall(). If this commit denotes the first working mlockall() would you
be so kind as to bump the __FreeBSD_version?