From owner-svn-src-all@FreeBSD.ORG Sun May 20 19:04:51 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9B86E106566B; Sun, 20 May 2012 19:04:51 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 1C9A38FC0A; Sun, 20 May 2012 19:04:49 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id WAA13338; Sun, 20 May 2012 22:04:41 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1SWBQm-000G3h-SB; Sun, 20 May 2012 22:04:40 +0300 Message-ID: <4FB94046.7090108@FreeBSD.org> Date: Sun, 20 May 2012 22:04:38 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:12.0) Gecko/20120503 Thunderbird/12.0.1 MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <201205151707.q4FH7UDU096834@svn.freebsd.org> <20120520110815.GB1442@garage.freebsd.pl> In-Reply-To: <20120520110815.GB1442@garage.freebsd.pl> X-Enigmail-Version: 1.5pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r235478 - head/cddl/contrib/opensolaris/cmd/zpool X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 May 2012 19:04:51 -0000 on 20/05/2012 14:08 Pawel Jakub Dawidek said the following: > On Tue, May 15, 2012 at 05:07:30PM +0000, Andriy Gapon wrote: >> Author: avg Date: Tue May 15 17:07:29 2012 New Revision: 235478 URL: >> http://svn.freebsd.org/changeset/base/235478 >> >> Log: zpool_do_import: use /dev instead of /dev/dsk as a default >> >> This affects behavior of zpool import without -d option. > > How does it affect 'zpool import' behaviour? On FreeBSD when -d is not > given we should not scan entire /dev/, but take all available GEOM Here is a discussion thread that lead to this commit: http://thread.gmane.org/gmane.os.freebsd.current/141813 > providers from the GEOM. > >> Reported by: Bruce Cran Submitted by: Fabian Keil >> MFC after: 2 weeks >> >> Modified: head/cddl/contrib/opensolaris/cmd/zpool/zpool_main.c >> >> Modified: head/cddl/contrib/opensolaris/cmd/zpool/zpool_main.c >> ============================================================================== >> >> --- head/cddl/contrib/opensolaris/cmd/zpool/zpool_main.c Tue May 15 16:17:30 2012 (r235477) >> +++ head/cddl/contrib/opensolaris/cmd/zpool/zpool_main.c Tue May 15 >> 17:07:29 2012 (r235478) @@ -1909,7 +1909,7 @@ zpool_do_import(int argc, >> char **argv) >> >> if (searchdirs == NULL) { searchdirs = safe_malloc(sizeof (char *)); - >> searchdirs[0] = "/dev/dsk"; + searchdirs[0] = "/dev"; nsearch = 1; } >> > -- Andriy Gapon