From owner-freebsd-ports@FreeBSD.ORG Sat May 31 08:38:26 2008 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3816A106566B for ; Sat, 31 May 2008 08:38:26 +0000 (UTC) (envelope-from matthias.andree@gmx.de) Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by mx1.freebsd.org (Postfix) with SMTP id 781D18FC16 for ; Sat, 31 May 2008 08:38:25 +0000 (UTC) (envelope-from matthias.andree@gmx.de) Received: (qmail invoked by alias); 31 May 2008 08:11:44 -0000 Received: from f049175133.adsl.alicedsl.de (EHLO m2a2.dyndns.org) [78.49.175.133] by mail.gmx.net (mp016) with SMTP; 31 May 2008 10:11:44 +0200 X-Authenticated: #428038 X-Provags-ID: V01U2FsdGVkX19N+kdbH/1NhrNwnhOaFgoCfv4uOGcjydjCnj7yUd gaQU7roIWXqEvw Received: from localhost (localhost [127.0.0.1]) by merlin.emma.line.org (Postfix) with ESMTP id 2A789200E80; Sat, 31 May 2008 10:11:43 +0200 (CEST) X-Virus-Scanned: amavisd-new at emma.line.org Received: from m2a2.dyndns.org ([127.0.0.1]) by localhost (m2a2.dyndns.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6HtTkzs1DD9d; Sat, 31 May 2008 10:11:43 +0200 (CEST) Received: by merlin.emma.line.org (Postfix, from userid 500) id DE63C200EAA; Sat, 31 May 2008 10:11:42 +0200 (CEST) Date: Sat, 31 May 2008 10:11:42 +0200 From: Matthias Andree To: Chuck Swiger Message-ID: <20080531081142.GB8828@merlin.emma.line.org> Mail-Followup-To: Chuck Swiger , freebsd-ports@freebsd.org References: <026785BB-C100-454B-88E4-E2D668721D78@mac.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <026785BB-C100-454B-88E4-E2D668721D78@mac.com> X-PGP-Key: http://home.pages.de/~mandree/keys/GPGKEY.asc User-Agent: Mutt/1.5.18 (2008-05-17) X-Y-GMX-Trusted: 0 Cc: freebsd-ports@freebsd.org Subject: Re: archivers/lzo2 selftest is a little much...? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 May 2008 08:38:26 -0000 On Fri, 30 May 2008, Chuck Swiger wrote: > I'm all for having software do a sanity check before being used, but the > recent update to archivers/lzo2 (lzo2-2.03) generates some ~28,000+ lines > of output. Please consider a change like: > > --- ports/archivers/lzo2/Makefile~ Fri May 30 18:33:46 2008 > +++ ports/archivers/lzo2/Makefile Fri May 30 19:05:55 2008 > @@ -25,3 +25,3 @@ > > -post-build: > +test: > cd ${WRKSRC} && ${MAKE} test Hi Chuck, And that would magically both run the test at build time (the only time when it makes sense - bust packages if the self-test fails, so that we don't run b0rked compression libraries underneath openvpn or thereabouts) and suppress the output at the same time? :-) I'll see to the issue (and to Pedro's suggestion), but it may take a few days until I get around to it. Taxes pending... -- Matthias Andree