From owner-freebsd-stable@freebsd.org Sat Jan 16 13:28:31 2016 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6CB89A8469B for ; Sat, 16 Jan 2016 13:28:31 +0000 (UTC) (envelope-from 000.fbsd@quip.cz) Received: from elsa.codelab.cz (elsa.codelab.cz [94.124.105.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EA97913C9 for ; Sat, 16 Jan 2016 13:28:30 +0000 (UTC) (envelope-from 000.fbsd@quip.cz) Received: from elsa.codelab.cz (localhost [127.0.0.1]) by elsa.codelab.cz (Postfix) with ESMTP id 0E91C28428; Sat, 16 Jan 2016 14:28:27 +0100 (CET) Received: from illbsd.quip.test (ip-86-49-16-209.net.upcbroadband.cz [86.49.16.209]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by elsa.codelab.cz (Postfix) with ESMTPSA id 81A8E2843A; Sat, 16 Jan 2016 14:28:25 +0100 (CET) Message-ID: <569A4579.8010208@quip.cz> Date: Sat, 16 Jan 2016 14:28:25 +0100 From: Miroslav Lachman <000.fbsd@quip.cz> User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:35.0) Gecko/20100101 Firefox/35.0 SeaMonkey/2.32 MIME-Version: 1.0 To: Philippe Michel , freebsd-stable@freebsd.org Subject: Re: make installworld creates empty dirs which are deleted by make delete-old References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jan 2016 13:28:31 -0000 Philippe Michel wrote on 01/16/2016 13:51: > On Sat, 16 Jan 2016, freebsd-stable-request@freebsd.org wrote: > >> I updated the server 3 times in one week (to 10.2-p8, -p9, -p10). > >> Those directories were deleted by delete-old >> >> # make -DBATCH_DELETE_OLD_FILES delete-old >> >>> Removing old files (only deletes safe to delete libs) >> >>> Old files removed >> >>> Removing old directories >> /usr/share/doc/atf >> /usr/share/atf >> /usr/include/atf-c++ >> /usr/include/atf-c >> >>> Old directories removed >> To remove old libraries run 'make delete-old-libs'. >> >> By after next installworld, they are back. > > You build world WITHOUT_TESTS=true, don't you ? > > There are many of these flags that are somehow missed when creating > directories at install. I don't use WITHOUT flags for buildworld / installwordl. The only WITHOUT is one for kernel: WITHOUT_KERNEL_SYMBOLS=yes Full content of src.conf and make.conf root@sm-reserve ~/# cat /etc/src.conf ## src.conf WITHOUT_KERNEL_SYMBOLS=yes root@sm-reserve ~/# cat /etc/make.conf ## make.conf WITH_PKGNG= yes SVN_UPDATE=yes SVN="/usr/local/bin/svnup" SVNFLAGS="" WITH_GHOSTSCRIPT_VER=9 DEFAULT_VERSIONS= perl=5.20 mysql=5.5m php=55 python=2.7 apache=2.4 ## https://wiki.freebsd.org/Ports/Options/OptionsNG ## OptionsNG sets DOCS, EXAMPLES and NLS as default - we do not need them OPTIONS_UNSET= X11 GUI CUPS DOCS EXAMPLES NLS ## cd /usr/ports/www/apache22 && make print-closest-mirrors MASTER_SITE_APACHE_HTTPD?= http://apache.miloslavbrada.cz/httpd/ http://mirror.hosting90.cz/apache/httpd/ ftp://mirror.hosting90.cz/apache/httpd/ http://www.eu.apache.org/dist/httpd/ ## closest PHP mirror MASTER_SITE_PHP= http://cz.php.net/%SUBDIR%/ > FWIW, with more WITHOUT flags set to true, my own list of directories > created again and again is : >>>> Removing old directories > /usr/share/snmp/mibs > /usr/share/snmp/defs > /usr/share/snmp > /usr/share/examples/pf > /usr/share/examples/ipfilter > /usr/share/examples/hast > /usr/share/examples/bhyve > /usr/share/doc/smm/07.lpd > /usr/share/doc/atm > /usr/share/doc/atf > /usr/share/atf > /usr/libexec/lpr/ru > /usr/libexec/lpr > /usr/include/netnatm/sig > /usr/include/netnatm/saal > /usr/include/netnatm/msg > /usr/include/netnatm/api > /usr/include/netgraph/bluetooth/include > /usr/include/netgraph/bluetooth > /usr/include/krb5 > /usr/include/kadm5 > /usr/include/gpib > /usr/include/dev/ieee488 > /usr/include/bsnmp > /usr/include/atf-c++ > /usr/include/atf-c > /etc/bluetooth > /etc/autofs >>>> Old directories removed > > I think some similar cases were fixed a few months ago by NGie Cooper > but it was apparently those he stumbled on by himself or some specific > bug reports rather than the start of a more exhaustive sweep. > > I suppose opening a PR could have helped but I procrastinated :-(. OK, I will open PR for this today. Thank you for your suggestions. Miroslav Lachman