Date: Fri, 11 Jan 2019 17:14:13 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 234833] USES=autoreconf fails if a port uses gettext but user disables NLS port option Message-ID: <bug-234833-7788-jlMcTqOjVS@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-234833-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-234833-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234833 --- Comment #5 from Matthias Andree <mandree@FreeBSD.org> --- (In reply to Mathieu Arnold from comment #4) Mathieu, sorry for misaddressing you as Antoine. When I read "... [gettext] Which you will most probably already have instal= led because there are many ports that require NLS anyway", I find that presumptuous. There are valid reasons to globally disable NLS through /etc/make.conf, for instance, on embedded systems.=20=20 I also agree that the workaround in mail/fetchmail seems overengineered - a= nd that's the actual reason why I have written this PR. My request is to extend the framework so that ports need to work around it = and re-implement parts of it. However this is implemented, several ways are possible. Mk/Uses/autoreconf.mk does not currently provide for a way to ea= sily add command-line options, and offers no way to add to its environment. One pretty generic option might be to add AUTORECONF_ENV and AUTORECONF_ARGS variables that autoreconf.mk uses, and that have similar semantics to CONFIGURE_ENV/_ARGS and MAKE_ENV/_ARGS.=20=20 A more specific one is to just disable autopoint with AUTOPOINT=3D${TRUE} i= n its environment, also in autoreconf.mk, if NLS is disabled, just like fetchmail= is currently playing it. There are surely other ways, but any proposal will need to make sure that * it is self-contained * does not break the port's build under non-malicious option combinations * does not pull in unneeded requisites * does declare indispensable/compulsory requisites. It's not as though I hadn't read through autoreconf.mk before writing this = PR, but I wasn't expecting so much opposition. --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-234833-7788-jlMcTqOjVS>