From owner-freebsd-arm@freebsd.org Sun Nov 12 15:40:27 2017 Return-Path: Delivered-To: freebsd-arm@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 658D3C0815E for ; Sun, 12 Nov 2017 15:40:27 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22b.google.com (mail-io0-x22b.google.com [IPv6:2607:f8b0:4001:c06::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 333C16B9BB for ; Sun, 12 Nov 2017 15:40:27 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22b.google.com with SMTP id u42so93380ioi.9 for ; Sun, 12 Nov 2017 07:40:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=4+c4xHKPjGGrpDiotHZ5lkzvtrSBSakIoJ+RZy47A3A=; b=ovZW9I8TcHXMxuE2XH9jByhnoLKIdZ+s8M9lu1a0dNINg5h3s905FpiW25CKemqzhA 0XpAphH1ntyRPjnb8NYYdEVq+GgtE67ZtDwrk9ZUFKVnMbOnS6J7Qrqfh9VBgGUtTVc1 nynZ6Zwg9cdZvb1558BDXBgfCqNeo+0SPFF4AxOH1Xb3+qaeULw4NcRK+47NRtU0ZBsb 3RIb9zGYPe5EO2J1FxI4tc8lWMIqgeo1YTvt25FLns1QpbvWh6fiywBw0ChkdmvyPoA1 1RiDUltGkgWPDybPKCSjXj7I2xAXBi4PKoRmngTQfdzfnv7AW/FLFlhGoEDD/nMcOYnr JiSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=4+c4xHKPjGGrpDiotHZ5lkzvtrSBSakIoJ+RZy47A3A=; b=Ww3ao/QDUw+gnWdEPieR+rbETUV2f2qnMe8NujAU061oDOqVIUEVZ6FAhSidtbuxcY pFUAF7D74hUtyoiPJyWIfTeWBvqwA14XRepmTMGB1BKit+JvBtvDldPgReMY2u+bDyH7 77kpyIbp12YckPzCLHXLWb6OfvpKUT8fA+0KK+MSI9ChILxGW6g+XZVu6Vk4FofzjdAN 4nG8DbQuahdJ37mzLJV53CunieuwtP972U0b+xlsecKCdZhM0REQ4m+XU4JMZm4ZFKca 6sIKKw+UC2lr0bSiwEDXr4bndhXUkPGLs+PwWISoHNUl0oclrwC6bOOMweXdZorji4+N Qdjg== X-Gm-Message-State: AJaThX7T69QxKEl20nVvSohD+BgfyPzrKqEQcGX6xegrbJza3bFPKaK0 y+BkNTOxWkWoVgZ28CYkB6lCvskyxPPY4n1T4Ju25Q== X-Google-Smtp-Source: AGs4zMYmJJgLMFuBAgCMwZ7gdjHcxtSUojN5zi+uz8jYWDuYkJo9VzJBLskFjFEGYx4ZmgNJlIo8RyDncILRp2TaTO0= X-Received: by 10.107.48.76 with SMTP id w73mr7267009iow.301.1510501226207; Sun, 12 Nov 2017 07:40:26 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.108.204 with HTTP; Sun, 12 Nov 2017 07:40:25 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:d8ae:193d:d5ec:7c8] Received: by 10.79.108.204 with HTTP; Sun, 12 Nov 2017 07:40:25 -0800 (PST) In-Reply-To: References: From: Warner Losh Date: Sun, 12 Nov 2017 08:40:25 -0700 X-Google-Sender-Auth: 8i2FAySGEjqmqAPhXZ3jEzKXWeY Message-ID: Subject: Re: RPI3 fails to boot: boot1.efi as bootaa64.efi on RPI3 [patch] To: Ed Maste Cc: Keith White , freebsd-arm@freebsd.org, Warner Losh Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2017 15:40:27 -0000 On Nov 12, 2017 7:56 AM, "Ed Maste" wrote: On 12 November 2017 at 08:11, Keith White wrote: > I've tried FreeBSD-12.0-CURRENT-arm64-aarch64-RPI3-20171030-r325156.img > and it fails to boot with an error similar to one reported by Mark Millard > in > https://lists.freebsd.org/pipermail/freebsd-arm/2017-September/016643.html > (Synchronous abort after displaying Load Path). Yes, unfortunately boot1.efi has been broken on PRi3 for months. A fix was committed in r325681 and will be in the next round of snapshots https://svnweb.freebsd.org/changeset/base/325681 jhb@ suggested checking the device for NULL as well, as in your patch, and I'll make that change shortly. In practice if the first call works the second will as well, but your version is an improvement in correctness. Makes sense to me. My fix for that just skipped it all if the first path was null. Of course, boot1.edi will be booted from the tree in the near term, so long term correctness doesn't matter. Warner