From owner-dev-commits-src-all@freebsd.org Sat Feb 27 06:57:13 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5A4BA55D8E4; Sat, 27 Feb 2021 06:57:13 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DnclY24YYz4VdZ; Sat, 27 Feb 2021 06:57:13 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from aniel.nours.eu (ns393929.ip-176-31-115.eu [176.31.115.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 208AC972C; Sat, 27 Feb 2021 06:57:13 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from [127.0.0.1] (10.246.39.62.rev.sfr.net [62.39.246.10]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aniel.nours.eu (Postfix) with ESMTPSA id 4FC0436B35; Sat, 27 Feb 2021 07:57:11 +0100 (CET) Date: Sat, 27 Feb 2021 06:57:07 +0000 (UTC) From: Baptiste Daroussin To: "Rodney W. Grimes" Cc: Enji Cooper , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Message-ID: In-Reply-To: <202102262257.11QMvJsL032239@gndrsh.dnsmgr.net> References: <202102262257.11QMvJsL032239@gndrsh.dnsmgr.net> Subject: Re: git: 2a50a9de8340 - main - terminfo: add terminfo database MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Correlation-ID: X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Feb 2021 06:57:13 -0000 26 f=C3=A9vr. 2021 23:57:25 Rodney W. Grimes : >> >> 26 f?vr. 2021 22:41:37 Enji Cooper : >> >>> >>>> On Feb 25, 2021, at 5:27 AM, Baptiste Daroussin wro= te: >>>> >>>> The branch main has been updated by bapt: >>>> >>>> URL: https://cgit.FreeBSD.org/src/commit/?id=3D2a50a9de8340f08bd876e9e= 5993332ae14376f80 >>>> >>>> commit 2a50a9de8340f08bd876e9e5993332ae14376f80 >>>> Author:???? Baptiste Daroussin >>>> AuthorDate: 2021-02-23 16:17:32 +0000 >>>> Commit:???? Baptiste Daroussin >>>> CommitDate: 2021-02-25 13:25:32 +0000 >>>> >>>> ?? terminfo: add terminfo database >>>> >>>> ?? Tested by:????? manu, jbeich >>> >>> Hi Baptiste, >>> ? A question and a comment: >>> ? 1. Was this reviewed in Phabricator? >>> ? 2. The details on why the terminfo database is being added are a bit = lean too to non-Unix users. It would be nice if the motivation for the chan= ge was documented in the commit message. >>> Thanks! >>> -Enji >> >> No it was not reviewed in phabricator as it does not really bring any co= de, but it was discussed on the mailing lists with a heads up on the plan a= nd the motivation, and all the reaction were in favor of this change. > > On what mailing list as I do not recall such a thread, which means I prob= ably need to add yet another list.=C2=A0 > >> Note thay while it could have been better written this commit is the thi= rd of a serie, where the first one explain a bit more things. >> >> Bapt > > -- > Rod Grimes=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= rgrimes@freebsd.org https://lists.freebsd.org/pipermail/freebsd-current/2020-May/076051.html