From owner-freebsd-current@FreeBSD.ORG Sun Nov 30 03:01:13 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4CB1F16A4CE; Sun, 30 Nov 2003 03:01:13 -0800 (PST) Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0568B43FCB; Sun, 30 Nov 2003 03:01:12 -0800 (PST) (envelope-from truckman@FreeBSD.org) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.12.9p2/8.12.9) with ESMTP id hAUB13eF024062; Sun, 30 Nov 2003 03:01:07 -0800 (PST) (envelope-from truckman@FreeBSD.org) Message-Id: <200311301101.hAUB13eF024062@gw.catspoiler.org> Date: Sun, 30 Nov 2003 03:01:03 -0800 (PST) From: Don Lewis To: shoesoft@gmx.net In-Reply-To: <1070183457.1099.2.camel@shoeserv.freebsd> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii cc: roger@FreeBSD.org cc: current@FreeBSD.org Subject: Re: panic on 5.2 BETA: blockable sleep lock X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Nov 2003 11:01:13 -0000 On 30 Nov, Stefan Ehmann wrote: > On Fri, 2003-11-28 at 01:02, Don Lewis wrote: >> On 27 Nov, Stefan Ehmann wrote: >> > On Wed, 2003-11-26 at 08:33, Don Lewis wrote: >> >> The problem is that selrecord() wants to lock a MTX_DEF mutex, which can >> >> cause a context switch if the mutex is already locked by another thread. >> >> This is contrary to what bktr_poll() wants to accomplish by calling >> >> critical_enter(). >> > >> > Strange enough that does not seem to happen with a kernel built without >> > INVARIANTS and WITNESS. Does this make any sense or is this just by >> > chance? >> >> You might try the patch below with WITNESS enabled. I don't have the >> hardware, so I can't test it. It compiles for me, but for all I know it >> could delete all your files if you run it. > > Any chance for getting this committed? I've been forwarding these messages to the bktr maintainer listed in /usr/src/MAINTAINERS, in case he isn't subscribed to current@. I'm not suprised that I haven't heard from him because this issue came up at the start of the Thanksgiving holiday weekend. Commiting the patch will also require re approval because of the code freeze in preparation for 5.2-RELEASE.