From owner-freebsd-stable@FreeBSD.ORG Tue Feb 2 14:28:20 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F0D8B106566B for ; Tue, 2 Feb 2010 14:28:20 +0000 (UTC) (envelope-from jdc@koitsu.dyndns.org) Received: from qmta10.emeryville.ca.mail.comcast.net (qmta10.emeryville.ca.mail.comcast.net [76.96.30.17]) by mx1.freebsd.org (Postfix) with ESMTP id CD1168FC0A for ; Tue, 2 Feb 2010 14:28:20 +0000 (UTC) Received: from omta13.emeryville.ca.mail.comcast.net ([76.96.30.52]) by qmta10.emeryville.ca.mail.comcast.net with comcast id d1M41d00817UAYkAA2UMlT; Tue, 02 Feb 2010 14:28:21 +0000 Received: from koitsu.dyndns.org ([98.248.46.159]) by omta13.emeryville.ca.mail.comcast.net with comcast id d2UL1d0063S48mS8Z2ULQ9; Tue, 02 Feb 2010 14:28:21 +0000 Received: by icarus.home.lan (Postfix, from userid 1000) id 8D8541E3035; Tue, 2 Feb 2010 06:28:19 -0800 (PST) Date: Tue, 2 Feb 2010 06:28:19 -0800 From: Jeremy Chadwick To: freebsd-stable@freebsd.org Message-ID: <20100202142819.GA71870@icarus.home.lan> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Subject: Re: patch for /usr/bin/mail X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2010 14:28:21 -0000 On Tue, Feb 02, 2010 at 02:21:44PM +0000, Pete French wrote: > This patch fixes a problem of mail missing addresses when replying > to emails generated by some Microsoft systems, which do not insert a > space after the comma in lists of addresses. Was filed as PR bin/131861 > If anyone who still uses /usr/bin/mail as their primarly email client > could test it then I would be grateful (would also be garetful if > someone could volunteer to commit it shold it prove to work fine :-) ) > > -pete. > > --- usr.bin/mail/util.c.orig 2010-02-02 14:10:34.220987358 +0000 > +++ usr.bin/mail/util.c 2010-02-02 14:12:49.968147827 +0000 > @@ -496,10 +496,10 @@ > *cp2++ = ' '; > } > *cp2++ = c; > - if (c == ',' && *cp == ' ' && !gotlt) { > + if (c == ',' && (*cp == ' ' || *cp == '"') && !gotlt) { > *cp2++ = ' '; > - while (*++cp == ' ') > - ; > + while (*cp == ' ') > + cp++; > lastsp = 0; > bufend = cp2; > } For what it's worth: note that Outlook, by default, uses semi-colon as its delimiter between addresses in To/Cc/Bcc fields. The SMTP portion of the Exchange interface might turn these into commas though, but I'm not 100% certain (I'd have to manually check -- let me know if you want me to). -- | Jeremy Chadwick jdc@parodius.com | | Parodius Networking http://www.parodius.com/ | | UNIX Systems Administrator Mountain View, CA, USA | | Making life hard for others since 1977. PGP: 4BD6C0CB |