From nobody Fri Feb 6 14:41:10 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f6xbq2l7Nz6RHRN; Fri, 06 Feb 2026 14:41:11 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f6xbq22wQz3ksF; Fri, 06 Feb 2026 14:41:11 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770388871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3D4BVww5Ty9bL3D49MTiHbH8xahbORvPsrzW9Z/7T7Y=; b=lOpVgPOjjpOPJympioNH5JUOv8mBjJF2QpoUXUf1fn6mXKhCQLsmqLOk9Y1UDOv/mEKsyk WBJOq5LzdcEK9WAqvrC+FohnloRQBH/Zj9cRY/74sMiYr+2toXrW2jIEp3ec2IE8JIrYtT 2ycnB0lf6yDKQDluM+Jbf3sBxvneUBarul4Rh+XOz9FLF7WMZxesCJfZy7rocJ0zfW0n8Q EggmN1AyA/EPkAnwX8/KgK3Mfwyyz1qjInU0NrBRKNWBIWeqejWlV2y1wGesmNKZbAMyZC raPnJ3PZ9TWDIHffGsvui36TzKv4lY5nbYixaPISjEUBYJk8hivTRRsj35p6hA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770388871; a=rsa-sha256; cv=none; b=tK4t5UXOPdpxIIim97+OHTG8EawpEytgKCE4bINfkAygEVTs2iQ8cYRwi7j18Tv39cXO0h A5rcSxvaCA74+FaDUyYQQcZAr0cNidQ+mQLAqivFplNDybPYcYVaYfpoOGmk8NYPoZkqkA IfC/XC9AOzCkz+pTuUfAp3pLSFimV9lEgLrAITgwJrMm4z5NjImizAwXtvqNbA99Z4x/ks ujXVYcy7H8NMoYBu3OyxOfzC9rjIuYJaNlIwxyWAD+Yh5zP7TzEJ8i2tYtD9BtV4avbVR5 DYewXBAosyyRfPxd5gzqklGi62iNp1AKE0v6TA5G7DKnzLuZhm34HcDd3HU8rg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770388871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3D4BVww5Ty9bL3D49MTiHbH8xahbORvPsrzW9Z/7T7Y=; b=EGwszruEG7fjKtTSTmL+GO0XEAjwkSQblA/+P7Xldt1JZGxa5Qi4cw0wzcOC2K4hF+eNAB fsfDtFUVPwUY9ox/t9QT84zGDISQ1DfIHGnMVF728OWHh9w2z7SvuykK2c7nHG9DRow3SI OJdQiYMACdC2wiZGoDAyw4U3i9qV+1Zfz/L7GXdS+PFA5p6bhEIai9e0RnH+xgk4u4Jdno Bl1K9oMuke7+oZz4gTf/MMuNzVT/KLwCsQ/80PYzkOiccRx3YJ6IzK6jpQbLLlP/Gz0yN2 umku23nz3fOmCU8GY8+dLyG8DbWBKJZYCARfn1jgIqRrPI8UQIT9FTb0Bo5TvA== Received: from [IPV6:2601:5c0:4202:5670:3056:d8a1:5220:efe] (unknown [IPv6:2601:5c0:4202:5670:3056:d8a1:5220:efe]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4f6xbp73KZzKGB; Fri, 06 Feb 2026 14:41:10 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <11d5cb2d-7460-4bd9-a33c-e52343f30d1d@FreeBSD.org> Date: Fri, 6 Feb 2026 09:41:10 -0500 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 70aab985c300 - stable/15 - heimdal: Pass the correct pointer to free in an error case Content-Language: en-US To: Enji Cooper , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org References: <6982480e.3097b.628edb67@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <6982480e.3097b.628edb67@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/3/26 14:10, Enji Cooper wrote: > The branch stable/15 has been updated by ngie: > > URL: https://cgit.FreeBSD.org/src/commit/?id=70aab985c30092483b5b32cdd3750570ec3d9364 > > commit 70aab985c30092483b5b32cdd3750570ec3d9364 > Author: John Baldwin > AuthorDate: 2026-01-31 17:00:44 +0000 > Commit: Enji Cooper > CommitDate: 2026-02-03 19:09:55 +0000 > > heimdal: Pass the correct pointer to free in an error case > > This fixes a warning reported by GCC 14 on stable/14: > > crypto/heimdal/lib/hdb/keys.c:241:13: warning: 'free' called on pointer 'ext' with nonzero offset 16 [-Wfree-nonheap-object] > 241 | free(hist_keys); > | ^~~~~~~~~~~~~~~ > crypto/heimdal/lib/hdb/keys.c:234:15: note: returned from 'calloc' > 234 | ext = calloc(1, sizeof (*ext)); > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > Reviewed by: rmacklem, cy > Fixes: 5000d023a446 ("heimdal-kadmin: Add support for the -f dump option") > Differential Revision: https://reviews.freebsd.org/D54932 > > (cherry picked from commit b26a7af438f36dcde86f39a681123cc2140affb2) Why so eager to MFC all the heimdal fixes before the normal time? They aren't even compiled on stable/15 by default? These were at least 3 days later, but I think the last one I committed you merged the next day which seemed a bit odd. -- John Baldwin