From owner-svn-src-all@freebsd.org  Fri Oct 23 05:42:47 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5B886A1669A;
 Fri, 23 Oct 2015 05:42:47 +0000 (UTC)
 (envelope-from julian@freebsd.org)
Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 220E0AFA;
 Fri, 23 Oct 2015 05:42:46 +0000 (UTC)
 (envelope-from julian@freebsd.org)
Received: from Julian-MBP3.local
 (50-196-156-133-static.hfc.comcastbusiness.net [50.196.156.133])
 (authenticated bits=0)
 by vps1.elischer.org (8.15.2/8.15.2) with ESMTPSA id t9N5NRSd077400
 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);
 Thu, 22 Oct 2015 22:23:31 -0700 (PDT)
 (envelope-from julian@freebsd.org)
Subject: Re: svn commit: r289728 - head
To: Alexander Kabaev <kabaev@gmail.com>, Ed Maste <emaste@FreeBSD.org>
References: <201510220132.t9M1WBW9087666@repo.freebsd.org>
 <20151021214550.70b25f13@kan>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
From: Julian Elischer <julian@freebsd.org>
Message-ID: <5629C44A.8060205@freebsd.org>
Date: Fri, 23 Oct 2015 13:23:22 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0)
 Gecko/20100101 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20151021214550.70b25f13@kan>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Oct 2015 05:42:47 -0000

On 10/22/15 9:45 AM, Alexander Kabaev wrote:
> On Thu, 22 Oct 2015 01:32:11 +0000 (UTC)
> Ed Maste <emaste@FreeBSD.org> wrote:
>
>> Author: emaste
>> Date: Thu Oct 22 01:32:11 2015
>> New Revision: 289728
>> URL: https://svnweb.freebsd.org/changeset/base/289728
>>
>> Log:
>>    Warn that NOCLEAN is deprecated - use NO_CLEAN instead
>>    
>>    NO_CLEAN has been the correct spelling for over a decade.
>>
>> Modified:
>>    head/Makefile.inc1
>>
>> Modified: head/Makefile.inc1
>> ==============================================================================
>> --- head/Makefile.inc1	Thu Oct 22 01:04:31 2015
>> (r289727) +++ head/Makefile.inc1	Thu Oct 22 01:32:11
>> 2015	(r289728) @@ -128,6 +128,7 @@ SUBDIR+=etc
>>   .endif	# !empty(SUBDIR_OVERRIDE)
>>   
>>   .if defined(NOCLEAN)
>> +.warning NOCLEAN option is deprecated. Use NO_CLEAN instead.
>>   NO_CLEAN=	${NOCLEAN}
>>   .endif
>>   .if defined(NO_CLEANDIR)
>
> For some definition of 'correct'. It definitely is not for those who
> have -DNOCLEAN wired into their finger memory and above mentioned
> decade did not help with that any.
>
> I think some of the common spellings were left as is in great NO_<foo>
> revolution for a reason and I see no reason why the sudden itch to
> change that.

I can never remember what the right way for WITHXXX WITH_XXX DO_XXX   
NO_XXX  NOXXX  etc. is..  I go look for examples every time.