From owner-svn-src-all@freebsd.org Thu May 9 18:37:41 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 70422158A81D; Thu, 9 May 2019 18:37:41 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0FE3274A83; Thu, 9 May 2019 18:37:41 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id BCC1C146E3; Thu, 9 May 2019 18:37:40 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lj1-f173.google.com with SMTP id n4so2908075ljg.4; Thu, 09 May 2019 11:37:40 -0700 (PDT) X-Gm-Message-State: APjAAAUo0LwyD7aKD1IxN0uJIJLIkiTmKtepm0ljIYpj8RTfSaRH9Iqu y3B8BPkhj7HJIvJPeVD43+FUolY6rd9yGIzKfI0= X-Google-Smtp-Source: APXvYqyhZ+hMyi4cPfAdbAZn7f01k3M0adIijowj5K3OCA2/uHAjcDGdx7K206za/OpuT+Pie9zonmTObU1nLBNoOEo= X-Received: by 2002:a2e:9a17:: with SMTP id o23mr3161480lji.108.1557427059369; Thu, 09 May 2019 11:37:39 -0700 (PDT) MIME-Version: 1.0 References: <201905091806.x49I6Bx9067179@repo.freebsd.org> In-Reply-To: <201905091806.x49I6Bx9067179@repo.freebsd.org> From: Kyle Evans Date: Thu, 9 May 2019 13:36:56 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r347402 - head/sys/modules/ipsec To: "Andrey V. Elsukov" Cc: src-committers , svn-src-all , svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 0FE3274A83 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.995,0]; NEURAL_HAM_SHORT(-0.96)[-0.963,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 May 2019 18:37:41 -0000 On Thu, May 9, 2019 at 1:06 PM Andrey V. Elsukov wrote: > > Author: ae > Date: Thu May 9 18:06:11 2019 > New Revision: 347402 > URL: https://svnweb.freebsd.org/changeset/base/347402 > > Log: > Add if_ipsec.ko symlink to ipsec.ko kernel module. > > This add ability to automatically load ipsec kernel module, when > if_ipsec(4) virtual interface is created using ifconfig(8). > > Reviewed by: gallatin > MFC after: 1 week > Differential Revision: https://reviews.freebsd.org/D20169 > Hi, Any chance the mechanism I introduced for ifconfig mapping ifname <-> kld in r347241 would solve the same set of problems this would? (unsure if there are any non-ifconfig(8) problems in consideration) If we have more consumers of it than just vmnet (from a stable/ point of view) then I'd be more than happy to MFC that separately from the rest of the commit. Thanks, Kyle Evans