From owner-freebsd-ports  Tue Jun 30 12:41:14 1998
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id MAA19881
          for freebsd-ports-outgoing; Tue, 30 Jun 1998 12:41:14 -0700 (PDT)
          (envelope-from owner-freebsd-ports@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id MAA19867
          for <freebsd-ports@FreeBSD.org>; Tue, 30 Jun 1998 12:41:05 -0700 (PDT)
          (envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.8.8/8.8.5) id MAA00386;
	Tue, 30 Jun 1998 12:40:03 -0700 (PDT)
Received: from europe.std.com (europe.std.com [199.172.62.20])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id MAA19580
          for <FreeBSD-gnats-submit@freebsd.org>; Tue, 30 Jun 1998 12:38:51 -0700 (PDT)
          (envelope-from cmascott@world.std.com)
Received: from world.std.com by europe.std.com (8.7.6/BZS-8-1.0)
	id PAA09948; Tue, 30 Jun 1998 15:38:42 -0400 (EDT)
Received: from europa.my.pc (world-f.std.com) by world.std.com (TheWorld/Spike-2.0)
	id AA05643; Tue, 30 Jun 1998 15:35:46 -0400
Received: (from cem@localhost)
	by europa.my.pc (8.8.8/8.8.8) id PAA10467;
	Tue, 30 Jun 1998 15:35:20 -0400 (EDT)
	(envelope-from cem)
Message-Id: <199806301935.PAA10467@europa.my.pc>
Date: Tue, 30 Jun 1998 15:35:20 -0400 (EDT)
From: cmascott@world.std.com
Reply-To: cmascott@world.std.com
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: ports/7132: xview-lib 3.2.1 port: FreeBSD patch error
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         7132
>Category:       ports
>Synopsis:       xview-lib 3.2.1 port: FreeBSD patch error
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          open
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 30 12:40:03 PDT 1998
>Last-Modified:
>Originator:     Carl Mascott
>Organization:
>Release:        FreeBSD 2.2.6-RELEASE i386
>Environment:

>Description:

patch-ad contains an error (misplaced parenthesis).
The effect of the faulty line is to discard the
return value of the function and to set

	ne = NOTIFY_IMMEDIATE

>How-To-Repeat:

	N/A

>Fix:
	
diff -ru bad_patches/patch-ad patches/patch-ad
--- bad_patches/patch-ad	Sat Oct 25 09:39:15 1997
+++ patches/patch-ad	Sat Jun 27 19:52:04 1998
@@ -1162,7 +1162,7 @@
   	    fprintf(stderr, "%s in unknown destroy status\n", arg1);
   	    goto Error;
   	}
-! 	if ((ne = notify_post_destroy(client, status), NOTIFY_IMMEDIATE) != NOTIFY_OK) {
+! 	if ((ne = notify_post_destroy(client, status, NOTIFY_IMMEDIATE)) != NOTIFY_OK) {
   	    if (!(status == DESTROY_CHECKING &&
   		  ne == NOTIFY_DESTROY_VETOED)) {
   		notify_perror("notify_destroy");

>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message