From owner-cvs-ports@FreeBSD.ORG  Tue Apr  3 18:59:48 2012
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53])
	by hub.freebsd.org (Postfix) with ESMTP id 0EB8B106564A;
	Tue,  3 Apr 2012 18:59:48 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from [127.0.0.1] (hub.freebsd.org [IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id 56399153E69;
	Tue,  3 Apr 2012 18:59:47 +0000 (UTC)
Message-ID: <4F7B48A3.30906@FreeBSD.org>
Date: Tue, 03 Apr 2012 11:59:47 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://www.FreeBSD.org/
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
	rv:11.0) Gecko/20120327 Thunderbird/11.0.1
MIME-Version: 1.0
To: Jason Helfman <jgh@FreeBSD.org>
References: <201204022351.q32NpP5N027328@repoman.freebsd.org>
In-Reply-To: <201204022351.q32NpP5N027328@repoman.freebsd.org>
X-Enigmail-Version: 1.4
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: 5u623l20@gmail.com, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org,
	ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/www/resin3 Makefile ports/www/resin3/files
 resin3.in resin3.sh.in
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Apr 2012 18:59:48 -0000

I realize that I haven't responded to your request to review changes to
this script (crazy busy), but looking at the resin3.in version quickly I
notice that this:

# REQUIRE: LOGIN NETWORKING SERVERS
# BEFORE: DAEMON

is impossible to fulfill. The BEFORE should be removed.

hth,

Doug


On 4/2/2012 4:51 PM, Jason Helfman wrote:
> jgh         2012-04-02 23:51:25 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     www/resin3           Makefile 
>   Added files:
>     www/resin3/files     resin3.in 
>   Removed files:
>     www/resin3/files     resin3.sh.in 
>   Log:
>   - reorg of rc script based on standards and move from .sh => .in
>   - bump PORTREVISION
>   
>   PR:     ports/166445  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=166445
>   Submitted by:   jgh (me)
>   Approved by:    maintainer, 5u623l20@gmail.com
>   Feature safe:   yes
>   
>   Revision  Changes    Path
>   1.47      +2 -1      ports/www/resin3/Makefile
>   1.1       +43 -0     ports/www/resin3/files/resin3.in (new)
>   1.2       +0 -43     ports/www/resin3/files/resin3.sh.in (dead)
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/resin3/Makefile.diff?&r1=1.46&r2=1.47&f=u
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/resin3/files/resin3.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/resin3/files/resin3.sh.in
>