From owner-svn-src-all@freebsd.org Thu Jan 14 09:27:56 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 98564A6D953; Thu, 14 Jan 2016 09:27:56 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-oi0-x22d.google.com (mail-oi0-x22d.google.com [IPv6:2607:f8b0:4003:c06::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5734617A6; Thu, 14 Jan 2016 09:27:56 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-oi0-x22d.google.com with SMTP id k206so111922476oia.1; Thu, 14 Jan 2016 01:27:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=K2pNrjPwUoYq8ez1oQ3eTVTLNu7fbQoT/4vys/MHR5Q=; b=G3MddVMd2EQ0QpJxmu54yooeRhkjhF9bCh+fTZQkaGRYBDNk5HM0DYPmVDL7V6SOze FjogHXuAYDyUydemlRn/X9IkW3PDZnjy52c2xY8HqCwq8zqv6z0Gj7tPdGvnUpLXmHcJ 0gWv8qWDRaTOsThw3We6mfJp5j4byB1+l1uIaCTYpheDjqzH9qhud4dOdBgiXeXJ0aSS W+ku5x2TQdxk1AvzC8V3M3DPXfK4xJEs/ahg/Kl69PIaX2dz0AuFkphGXda0M5spRWXN U4y5F0E4FVw2orvdtmD96C/qNCYozD2LQF7ngu3YBo7AYreFiocqKIWXEMQy6OzSrNFj eouQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=K2pNrjPwUoYq8ez1oQ3eTVTLNu7fbQoT/4vys/MHR5Q=; b=RopUPeOSHs4VpukNuNd6apEGSbJbB3aQmeIKlJKoMpK8WeC7zw0sVVTMvRgqj1nI9y O6KpsBTMK7N78QBkUBBcFjZnAZfh94HsvvJI8LQJVAsP6UBmkuHM3BQVW4idPW8O14s5 PzeNewCmHWLnU+BabY+ja/M5TUfJt2tTv9DF6PU+C+RCl2VtVf545uvFNylm/MB3WgFP sv1lsgQrm+9AKJF1wUtVHAfGz1IYj9ukrzHc/tQGZvscj+3dpL4wmPMx2g1hotR1on4j Icc7VKEs9Pa9k5bIpVzfTC5ls7zi0xPansF+d05w8yCHHbLQ8tH5AdQAiEC+iBD4TzbE oz9g== X-Gm-Message-State: ALoCoQn3ENFQf5j60FPS2hqkIEJsKO0bjF/+98prduAF+ZcR3bUEboCUdO+g10x7Xxusgwk/OjTXIqGETd9FdKatcH/x14cyLw== X-Received: by 10.202.197.82 with SMTP id v79mr2013628oif.60.1452763675609; Thu, 14 Jan 2016 01:27:55 -0800 (PST) Received: from ?IPv6:2601:601:800:126d:f478:ccdc:ca0f:26df? ([2601:601:800:126d:f478:ccdc:ca0f:26df]) by smtp.gmail.com with ESMTPSA id y9sm3110066obg.4.2016.01.14.01.27.53 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 14 Jan 2016 01:27:54 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: svn commit: r293903 - in head/sys/boot: arm/uboot efi/fdt efi/libefi From: NGie Cooper In-Reply-To: <201601140922.u0E9M1rV025146@repo.freebsd.org> Date: Thu, 14 Jan 2016 01:27:51 -0800 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201601140922.u0E9M1rV025146@repo.freebsd.org> To: Steven Hartland X-Mailer: Apple Mail (2.2104) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2016 09:27:56 -0000 > On Jan 14, 2016, at 01:22, Steven Hartland wrote: >=20 > Author: smh > Date: Thu Jan 14 09:22:01 2016 > New Revision: 293903 > URL: https://svnweb.freebsd.org/changeset/base/293903 >=20 > Log: > Fix GCC warnings causing build failure after r293724 >=20 > Disable some compiler warnings for GCC (non-standard compiler) fixing > build failures introduced by r293724, which enabled WARNS in the EFI = boot > code, when compiling with none standard compiler (GCC). Disabling warnings is wrong. Here=E2=80=99s how arm could be fixed: $ svn diff sys/boot/ Index: sys/boot/common/bootstrap.h =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/boot/common/bootstrap.h (revision 293877) +++ sys/boot/common/bootstrap.h (working copy) @@ -32,6 +32,7 @@ #include #include #include +#include =20 /* * Generic device specifier; architecture-dependant=20 @@ -332,12 +333,8 @@ extern struct arch_switch archsw; =20 /* This must be provided by the MD code, but should it be in the = archsw? */ -void delay(int delay); - void dev_cleanup(void); =20 -time_t time(time_t *tloc); - #ifndef CTASSERT /* Allow lint to override */ #define CTASSERT(x) _CTASSERT(x, __LINE__) #define _CTASSERT(x, y) __CTASSERT(x, y) Index: sys/boot/efi/include/efiapi.h =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/boot/efi/include/efiapi.h (revision 293877) +++ sys/boot/efi/include/efiapi.h (working copy) @@ -532,6 +532,7 @@ typedef EFI_STATUS (EFIAPI *EFI_RESERVED_SERVICE) ( + VOID ); =20 typedef amd64 is a bit trickier: /scratch/tmp/ngie/svn/sys/boot/efi/libefi/../include/efigop.h:75: = warning: 'ms_abi' attribute directive ignored I didn=E2=80=99t dig into why this is happening [yet], other than there = maybe being MS extensions involved? Thanks, -NGie=