From nobody Fri Jan 16 11:10:04 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dsxvx06BSz6P7Tf for ; Fri, 16 Jan 2026 11:10:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dsxvw4X9Bz3q8t for ; Fri, 16 Jan 2026 11:10:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768561804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uvXVmyXjeqC7tAiDuBik2yGgE7ll1CA1L95ZS9lOLKI=; b=RaZwsG/cmkmCsGwC6kiIyCBc2vgV+ObobWCXaKRi64v7a1w2TjWysYrKoNip5zyfgr2WYp RHBgzI6DBj2NkSFXhaXqWMgjQOl/n2No5SPTehOBb6E/MrV7kaBRHzwZQND4ZGujoHqcBs N+CLHeEu8GSi1L+GaCawXSef0g5njAuHRB0obwxWcSAsGdinXSVbzfAnBfkbEN+mG4QWTr Q68zHf5+TeeVzaQ0zWUl3/cAx9rnBwPJ4b7KXgZmXEaYQKshH4VKqx8s5SSsw8YpLJHYyO tgchAdy/VKYRiZ9mHCgW6RAo3FOW4aZbJkr5QygqKA2lV3WpYrGeIKLP8RV3rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768561804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uvXVmyXjeqC7tAiDuBik2yGgE7ll1CA1L95ZS9lOLKI=; b=olE1h/Y1xhRGpUD8WBajsVpN4EHBN7FbR9z1NfUiGM6XZdqXnqGCKL500n0/phUlEwjJRQ E2l/fGa6FX+Pmzw026dKfVqxQPpkefp1JxWSUgo/YYHc82R1Hsy4qTJGt9ViEDpYE+u5l+ A8DEEPAAuoPikuIGDzLrw9sXFxqe6+x+pNNWCtupZlkpEkZ6lL7ycGVI6zqESR8JW4BKwb baSrysKEGd7LSIpJy9XzrnYdmZZWeUG5Ak9ao2mqKfdr3lSEatB/7hiWjccZbk9KYZHNpl 33RAYpBsddnfwtaBRTYQIyvvxSvn3kkW3FUzaJRXnUWxhK6u00l895dbFAyvkg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1768561804; a=rsa-sha256; cv=none; b=m4bEPo+o84VRVJ61+0h9olf7pqgoP2xKVbtlaSqqAIgkjxsw4yc3sssjw4euKROZO6A9Rf Y6TWXRLVu2GAqr1cQn0nscePd9uilMgtiDi/NY5kbaJQEZ86AInMVLVfF61Uz3Gfxaz2Hg UyiP+cv7u4b4CeBOp5tmf0Qf8hKTKByKu5FyjxKcBkEvPuYAODce9v25BUGu65IveI99Ec rufI4kzkQmlN1rav6cAOV6bQwZ3e+IiUEeuo9NC7Ojq9AuoLvPilQe2OoxslaORuK8o3vm hFUdZ/X3r5jmjdKf7tgzTM3edzh2leUIQARAlbL2RX0JCYj0sh73ytuYODUfJA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dsxvw2C10z191h for ; Fri, 16 Jan 2026 11:10:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 33611 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 16 Jan 2026 11:10:04 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: f8ddf74175c8 - main - dwc: improve IPv4 transmit checksum offloading List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f8ddf74175c8013268e65b18750e247306fa088a Auto-Submitted: auto-generated Date: Fri, 16 Jan 2026 11:10:04 +0000 Message-Id: <696a1c8c.33611.6782849d@gitrepo.freebsd.org> The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=f8ddf74175c8013268e65b18750e247306fa088a commit f8ddf74175c8013268e65b18750e247306fa088a Author: Michael Tuexen AuthorDate: 2026-01-16 11:02:53 +0000 Commit: Michael Tuexen CommitDate: 2026-01-16 11:02:53 +0000 dwc: improve IPv4 transmit checksum offloading This patch provides two improvements for TCP/IPv4 and UDP/IPv4 transmit checksum offloading: (1) Use *CIC_SEG instead of *CIC_FULL, since FreeBSD always provides a pseudo header checksum. (2) Don't make transmit IPv4 header checksum offloading a prerequisite for TCP/IPv4 or UDP/IPv4 transmit checksum offloading. This is the root cause of PR 291696, since right now the epair interface does not support transmit IPv4 header checksum offloading, but TCP/IPv4 and UDP/IPv4 transmit checksum offloading. PR: 291696 Reviewed by: Timo Voelker Tested by: Marek Benc MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D54395 --- sys/dev/dwc/dwc1000_dma.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/sys/dev/dwc/dwc1000_dma.c b/sys/dev/dwc/dwc1000_dma.c index 44b9f0d114bf..8cc145216c2d 100644 --- a/sys/dev/dwc/dwc1000_dma.c +++ b/sys/dev/dwc/dwc1000_dma.c @@ -248,7 +248,7 @@ dma1000_setup_txbuf(struct dwc_softc *sc, int idx, struct mbuf **mp) struct bus_dma_segment segs[TX_MAP_MAX_SEGS]; int error, nsegs; struct mbuf * m; - uint32_t flags = 0; + uint32_t flags; int i; int last; @@ -276,19 +276,12 @@ dma1000_setup_txbuf(struct dwc_softc *sc, int idx, struct mbuf **mp) m = *mp; - if ((m->m_pkthdr.csum_flags & CSUM_IP) != 0) { - if ((m->m_pkthdr.csum_flags & (CSUM_TCP|CSUM_UDP)) != 0) { - if (!sc->dma_ext_desc) - flags = NTDESC1_CIC_FULL; - else - flags = ETDESC0_CIC_FULL; - } else { - if (!sc->dma_ext_desc) - flags = NTDESC1_CIC_HDR; - else - flags = ETDESC0_CIC_HDR; - } - } + if ((m->m_pkthdr.csum_flags & CSUM_DELAY_DATA) != 0) + flags = sc->dma_ext_desc ? ETDESC0_CIC_SEG : NTDESC1_CIC_SEG; + else if ((m->m_pkthdr.csum_flags & CSUM_IP) != 0) + flags = sc->dma_ext_desc ? ETDESC0_CIC_HDR : NTDESC1_CIC_HDR; + else + flags = sc->dma_ext_desc ? ETDESC0_CIC_NONE : NTDESC1_CIC_NONE; bus_dmamap_sync(sc->txbuf_tag, sc->txbuf_map[idx].map, BUS_DMASYNC_PREWRITE);