From owner-freebsd-scsi@FreeBSD.ORG Wed Jul 14 13:07:32 2010 Return-Path: Delivered-To: scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 16BC61065670 for ; Wed, 14 Jul 2010 13:07:32 +0000 (UTC) (envelope-from pawel.worach@gmail.com) Received: from mail-ew0-f54.google.com (mail-ew0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id 979278FC23 for ; Wed, 14 Jul 2010 13:07:31 +0000 (UTC) Received: by ewy26 with SMTP id 26so1549711ewy.13 for ; Wed, 14 Jul 2010 06:07:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:mime-version :content-type:from:in-reply-to:date:cc:content-transfer-encoding :message-id:references:to:x-mailer; bh=ORiCAmkXW6mGC1sL5Prkp65bKpJsfygNO7sttKnTslc=; b=RiyKQWsKfipOLjfhaK/Bi7Knwuh8iSevGMSDQ855HPNV9PM4nu0bipjT/zULQ2uOhe nTJH7wu7hXn2fp1jg8C5yWfjoJealgRF/+shrCxyW4dWnqbqp5YjnuQEWw1EmXwsvjTw WYopdn7Y+9zwHJ8Uc8DQPP7bu/XSmDmnLKKvw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; b=ax1u/f4U+tYGuFG0jIk5Tpm7jW78I2OUyBQA+PT+xG0LdKRZ1Ju48Ggg/eLdTD0Tef L4uAb5rCyxiAUhtj0OSYRaL1ZiHIY4OCqR0FM1BbhA2bvpBAtZXWK/CSJqiZU7VzhecQ KudJ5L1LHl4HyH4lOVUD45+ijCM5rhZ3sXnvM= Received: by 10.213.25.138 with SMTP id z10mr1246396ebb.84.1279112849643; Wed, 14 Jul 2010 06:07:29 -0700 (PDT) Received: from [172.16.0.199] (c80-216-186-179.bredband.comhem.se [80.216.186.179]) by mx.google.com with ESMTPS id v59sm57086184eeh.16.2010.07.14.06.07.28 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 14 Jul 2010 06:07:28 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v1081) Content-Type: text/plain; charset=us-ascii From: Pawel Worach In-Reply-To: <20100714115731.GA14537@duncan.reilly.home> Date: Wed, 14 Jul 2010 15:07:27 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <51186C1C-E61D-4A9D-8A78-749F48E89CE0@gmail.com> <20100714115731.GA14537@duncan.reilly.home> To: Andrew Reilly X-Mailer: Apple Mail (2.1081) Cc: scsi@freebsd.org Subject: Re: [patch] fix aicasm build with clang. X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jul 2010 13:07:32 -0000 On Jul 14, 2010, at 13:57, Andrew Reilly wrote: > On Wed, Jul 14, 2010 at 11:44:57AM +0200, Pawel Worach wrote: >> sys/dev/aic7xxx/aicasm/aicasm_gram.y:1826:51: error: use of logical = || with constant operand; switch to bitwise | or remove constant = [-Wlogical-bitwise-confusion] >> if (opcode =3D=3D AIC_OP_AND || opcode =3D=3D AIC_OP_JNZ || = AIC_OP_JZ) >> ^ ~~~~~~~~~ >>=20 >> Bug ? >=20 > Looks like one to me. There's no constant value of AIC_OP_JZ > that can make its inclusion in that line interesting, as is (it > is probably non-zero, which means that the if-body is always > executed. I think that your patch is almost certainly correct. >=20 > [What down-stream effect does this bug have on the SCSI > controller microcode in question?] >=20 Hmm, it looks like that really broke the assembler... ../aicasm/aicasm: Stopped at file = /data/buildslave/freebsd-clang-amd64/src-freebsd/sys/modules/aic7xxx/ahc/.= ./../../dev/aic7xxx/aic7xxx.seq, line 103 - Invalid bit(s) 0x1 in = immediate written to ARG_1 ../aicasm/aicasm: Removing aic7xxx_seq.h due to error --=20 Pawel=