From owner-freebsd-ports@FreeBSD.ORG Sun Feb 6 15:51:34 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1E2C61065675 for ; Sun, 6 Feb 2011 15:51:34 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 9E94F8FC1D for ; Sun, 6 Feb 2011 15:51:33 +0000 (UTC) Received: by bwz12 with SMTP id 12so4153315bwz.13 for ; Sun, 06 Feb 2011 07:51:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=tVSbZS22Xn7sfHXg/FUWpTbp3Hal6CUd8ZTgi17lqzI=; b=ddN/VbcaOhzQ2+xI06z2JahXHRvMTCed2NC/iGm9gtpIUQQfJ+A09Rist9YbPUHP88 pzZGRWBGw6B2nC2h8hOkgLiHF16JvtIO7U+FtayqSjY7Px4glbepHPChOkiKPvD5YaHa ySd9lTSrbg8OmuKK7z7Z84miFJFvCk9GBym/I= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:reply-to:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; b=rhw0vYCoZHyQ1NCOS5Qt41nYe11bP74h//ORR1H6DXnngkA6oRy8i4X9oJ+iWE1lBX FWnj3WyoHUohtOcDdkPCRyN9zds2adyKs5sm2KcmRUITbMVO93pIsyRp8CmmmeXRTrvx sp2h4t4EcBOPXn2HpGfOAV3XC47OcVpB8+c3Y= Received: by 10.204.85.11 with SMTP id m11mr14256177bkl.115.1297007492242; Sun, 06 Feb 2011 07:51:32 -0800 (PST) MIME-Version: 1.0 Received: by 10.204.16.142 with HTTP; Sun, 6 Feb 2011 07:51:01 -0800 (PST) In-Reply-To: <87zkq91abv.fsf@gmail.com> References: <8762syroh6.fsf@gmail.com> <87zkq91abv.fsf@gmail.com> From: Chris Rees Date: Sun, 6 Feb 2011 15:51:01 +0000 Message-ID: To: Raphael Kubo da Costa Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-ports@freebsd.org Subject: Re: Call for testers: projectM comes to FreeBSD! [re ports/152823] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: utisoft@gmail.com List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Feb 2011 15:51:34 -0000 On 6 February 2011 14:55, Raphael Kubo da Costa wrote: > Chris Rees writes: > >>> + @${REINPLACE_CMD} -e '/return NULL/d' ${WRKSRC}/actor_projectM.cpp >>> >>> Is this one from upstream? If so, isn't it better to put it in files/? >> >> No, this is one I made. They've written a dummy function in, but it's >> type struct * and tries to return NULL. > > Hmm, if it's a function with a return type other than void, it should > return at least something. > >> I have a serious hatred of files/patch-*; they break with most >> updates, they bloat the repository and make it slower for everyone to >> csup as well. I thought that a ${REINPLACE_CMD} was a cleaner way of >> doing so. > > To be honest (note I'm not a ports committer, so there might be reasons > for this), I don't personally like the current way patches are added: > it's better than when they were just called patch-aa and nobody would > ever be able to know what their purpose was (the CVS log normally > wouldn't help much), however it's still hard to tell when something was > obtained from upstream or is something local, if upstream has been > contacted about the patch or what exactly it is supposed to fix. Adding > some notes about this in the file before the diff itself would certainly > help a lot. > After discussion on #bsdports, they agree with you. I've changed it to a patchfile, and removed the only reference to that function as well. It's a dummy call, anyway. Chris