From nobody Sat Apr 25 16:29:08 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g2wJP2WyJz6bmDp for ; Sat, 25 Apr 2026 16:29:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g2wJP0SdQz44Lv for ; Sat, 25 Apr 2026 16:29:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777134549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ku4OtOGEgU6A1Toj7CYc6HbiS2mSxj0njeER7cHbQAw=; b=Vva59E6e5JqgXXIy3BCQlBEJHK5tC1m/mrZ4ZWuVVfJXvkF5LHhq/tl/4esAv3gn6GmbL/ i+1UV7L5pH0T87nkn66PSraXlke7LEmy9T1pZz8ibTZh6mAQm9RpNiMB8lzxJ7W+TR3c07 dipRBlwqeVO4vwzSp43kGeLguSbIghsZaBorvc2bla6Kq6z4wBW1NB2epdu7fMlUuKEbYp FgcZTYEyhF1XKl2qJgjp9nc2hYTeK6TqAaWUd0nwW7rG6l99Z4++ixjW8OQlbDMDsnVmZ0 dFBauXkf1fvX7chIO2E7Jy3hImorwCI9RvDWDU5NfJxdZXq/zfDfcDAqF167wA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777134549; a=rsa-sha256; cv=none; b=uEKjQ9hIQwVcYx+44X08VhgxcAfnyrmtZDiWKlZgOhlybtKVan3DxirTJBkTC3stxNr7jc kh/JTF5l+7ZHt0lMr7/yWVyHG6juPWwrCuUUxYrsz61a/awQV89yeYsLXRL+CgR7taYj9D CwH9gRgYtMyYIhqVN725KMpqltKyw88JmFtTYxJXo1L9MX1H87bGqMkYddpu/HjeM0VbY2 Df+Sxv9Xaktu+/5SvPcx3rl2PKodp97MbYNB5eM/jDkxlUf6avAr5f9IjNOQReu4GEgcKg XcRvoz1xcdNcVLuc/TKlIv+sAM8BlwLCcviU3p2jL6F6qpph6CV+wMmtVGRBaQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777134549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ku4OtOGEgU6A1Toj7CYc6HbiS2mSxj0njeER7cHbQAw=; b=v7m6xMordv+WsCWgh6pCZS6TdGUMN3EQjW4gbV5sxywITw3s1rwZJX+YURklgS0Xdy5Yrz 2LiGqv7tIZT5PRSF4BYjZpYQ/yZITvVUamh5BqAjJDVFfXlmnXsqSpYz/Vgv+2c8K4ZtXN T5sOF32GVMfsES7cnFGc7KL1PMa5om4ggHfEsVkCsw4YTU/BBcVe2b+vxBNn3gQTtG7g2k U/padLlv8FAKESizUQ8FmZh6J8BuOxGGNsLvIjEPPUnmJdEonkiiU8ybFZVRG6P9TQPx4J XPkjS7wengcIsSZo78fn7a6yZTWyV3qqBh4uE1Lk8vq9+9pl3U/2KKogMwZwOA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g2wJN6sv6zhHV for ; Sat, 25 Apr 2026 16:29:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 44b70 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 25 Apr 2026 16:29:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Enji Cooper Subject: git: 41924423f7eb - stable/14 - asmc: use `ASMC_FAN_FUNCS2` with the Macmini4,1 List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ngie X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 41924423f7eb6e84449a37d5273598e665cd138f Auto-Submitted: auto-generated Date: Sat, 25 Apr 2026 16:29:08 +0000 Message-Id: <69ecebd4.44b70.4670c26c@gitrepo.freebsd.org> The branch stable/14 has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=41924423f7eb6e84449a37d5273598e665cd138f commit 41924423f7eb6e84449a37d5273598e665cd138f Author: Enji Cooper AuthorDate: 2026-02-20 05:43:37 +0000 Commit: Enji Cooper CommitDate: 2026-04-25 16:29:03 +0000 asmc: use `ASMC_FAN_FUNCS2` with the Macmini4,1 The Macmini4,1 model does not have "fansafespeed" support. This issue typically manifests with messages like so: ``` asmc0: asmc_key_read for key F0Sf failed 10 times, giving up ``` Swap out `ASMC_FAN_FUNCS` with `ASMC_FAN_FUNCS2` to explicitly drop "fansafespeed" checks in the driver for the model as it doesn't support that hardware feature. MFC after: 1 week Reported by: @probonopd Closes: https://github.com/helloSystem/ISO/issues/357 (cherry picked from commit 7b862cf8a252d80ab1fb90fa5371fd8462c7c16f) --- sys/dev/asmc/asmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/asmc/asmc.c b/sys/dev/asmc/asmc.c index 066b9c80de23..5620c8c42d89 100644 --- a/sys/dev/asmc/asmc.c +++ b/sys/dev/asmc/asmc.c @@ -347,7 +347,7 @@ static const struct asmc_model asmc_models[] = { { "Macmini4,1", "Apple SMC Mac mini 4,1 (Mid-2010)", ASMC_SMS_FUNCS_DISABLED, - ASMC_FAN_FUNCS, + ASMC_FAN_FUNCS2, ASMC_LIGHT_FUNCS_DISABLED, ASMC_MM41_TEMPS, ASMC_MM41_TEMPNAMES, ASMC_MM41_TEMPDESCS },