From owner-svn-src-all@freebsd.org Fri May 11 10:07:24 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CF99DFCC668; Fri, 11 May 2018 10:07:24 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4CD2D7691B; Fri, 11 May 2018 10:07:24 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w4BA7D50097702 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 11 May 2018 13:07:16 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w4BA7D50097702 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w4BA7DfG097701; Fri, 11 May 2018 13:07:13 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 11 May 2018 13:07:13 +0300 From: Konstantin Belousov To: Conrad Meyer Cc: Ed Maste , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333461 - head/sys/amd64/amd64 Message-ID: <20180511100713.GG6887@kib.kiev.ua> References: <201805101501.w4AF1iI0039082@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.5 (2018-04-13) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2018 10:07:25 -0000 On Thu, May 10, 2018 at 07:57:03PM -0700, Conrad Meyer wrote: > On Thu, May 10, 2018 at 8:01 AM, Konstantin Belousov wrote: > > Author: kib > > Date: Thu May 10 15:01:43 2018 > > New Revision: 333461 > > URL: https://svnweb.freebsd.org/changeset/base/333461 > > > > Log: > > Make fpusave() and fpurestore() on amd64 ifuncs. > > > > From now on, linking amd64 kernel requires either lld or newer ld.bfd. > > Hi, > > This commit seems to break amd64-gcc cross toolchain build (note, this > is a cc error, not ld): > > In file included from /usr/src/sys/amd64/amd64/fpu.c:64:0: > /usr/src/sys/amd64/amd64/fpu.c:195:22: error: ifunc is not supported > on this target > DEFINE_IFUNC(, void, fpusave, (void *), static) > ^ > ./x86/ifunc.h:55:19: note: in definition of macro 'DEFINE_IFUNC' > qual ret_type name args __attribute__((ifunc(#name "_resolver"))); \ > ^~~~ > /usr/src/sys/amd64/amd64/fpu.c:202:22: error: ifunc is not supported > on this target > DEFINE_IFUNC(, void, fpurestore, (void *), static) > ^ > ./x86/ifunc.h:55:19: note: in definition of macro 'DEFINE_IFUNC' > qual ret_type name args __attribute__((ifunc(#name "_resolver"))); \ > ^~~~ > --- fpu.o --- > *** [fpu.o] Error code 1 On FreeBSD, gcc configuration requires explicit --enable-gnu-indirect-function option. I see it in e.g. lang/gcc7 port Makefile. On the other hand, I do not understand how devel/amd64-xtoolchain-gcc and devel/powerpc64-xtoolchain-gcc are build, so cannot see whether the switch is added to the configure invocation. But I suspect that it is not. In other words, most likely the problem is due to the port itself.