Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 11 Dec 2008 07:51:09 +0000 (UTC)
From:      Qing Li <qingli@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject:   svn commit: r185920 - projects/arpv2_merge_1/usr.sbin/arp
Message-ID:  <200812110751.mBB7p9Mq058395@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: qingli
Date: Thu Dec 11 07:51:09 2008
New Revision: 185920
URL: http://svn.freebsd.org/changeset/base/185920

Log:
  Simply remove the references to RTF_LLINFO.
  This flag is no longer set in the kernel so
  don't bother checking in userland app.

Modified:
  projects/arpv2_merge_1/usr.sbin/arp/arp.c

Modified: projects/arpv2_merge_1/usr.sbin/arp/arp.c
==============================================================================
--- projects/arpv2_merge_1/usr.sbin/arp/arp.c	Thu Dec 11 07:43:02 2008	(r185919)
+++ projects/arpv2_merge_1/usr.sbin/arp/arp.c	Thu Dec 11 07:51:09 2008	(r185920)
@@ -370,13 +370,6 @@ set(int argc, char **argv)
 		if (addr->sin_addr.s_addr != dst->sin_addr.s_addr)	
 			break;
 		if (sdl->sdl_family == AF_LINK &&
-#if 0
-		    /*
-		     * XXX Qing - how should this be handled?
-		     *
-		     */
-		    (rtm->rtm_flags & RTF_LLINFO) &&
-#endif		    
 		    !(rtm->rtm_flags & RTF_GATEWAY) &&
 		    valid_type(sdl->sdl_type) )
 			break;
@@ -447,21 +440,10 @@ delete(char *host, int do_proxy)
 		sdl = (struct sockaddr_dl *)(SA_SIZE(addr) + (char *)addr);
 		if (addr->sin_addr.s_addr == dst->sin_addr.s_addr &&
 		    sdl->sdl_family == AF_LINK &&
-#if 0
-		    /*
-		     * XXX Qing - how should this be handled?
-		     *
-		     */
-		    (rtm->rtm_flags & RTF_LLINFO) &&
-#endif		    
 		    !(rtm->rtm_flags & RTF_GATEWAY) &&
 		    valid_type(sdl->sdl_type) )
 			break;	/* found it */
 
-		/* Qing
-		 * why not just remove the RTF_LLINFO in the above
-		 * code instead of another "if", works 
-		 */
 		if (sdl->sdl_family == AF_LINK &&
 		    !(rtm->rtm_flags & RTF_GATEWAY) &&
 		    valid_type(sdl->sdl_type) ) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200812110751.mBB7p9Mq058395>