From owner-svn-src-all@freebsd.org Fri Sep 2 23:29:48 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E6252BCD737 for ; Fri, 2 Sep 2016 23:29:48 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-wm0-x232.google.com (mail-wm0-x232.google.com [IPv6:2a00:1450:400c:c09::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7CB05DFF for ; Fri, 2 Sep 2016 23:29:48 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by mail-wm0-x232.google.com with SMTP id w2so49555987wmd.0 for ; Fri, 02 Sep 2016 16:29:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=mSvX/an9u+jA+cdejxQwgG4vMhZnI7UZ9AITpVkA0xI=; b=BQi6LTxpUGPCNhs/ncGNJCC+3ygSr68pt5gQS70e8rnDeFoMhKgzjbRay1+MznY4Vo ZlkJRf4kSdc1J6Zw+T/7BzNGA8Z6jBGWUl+JiBiMSFuzh4QmM3EuCGhgcg6jjRyWOTyd Ptu3MXFcMra0DO61T0UV79ZhW5rHDJK9fVf+qJur64kSsV10X7rJHwS6dUYpsOGM/Q3x II7Bmy/VK+AmQQqCsKPfWiZRVwPqZrzvE29ftYVtdjH7JiG7WS//yFOsSLQu6AosBNJW HPzOKPxM/ft8U014py+XS9/UaWAmej/fRnY1SjQUdrukZaHfvXmji3xKXrLuaXabNwQs LeHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=mSvX/an9u+jA+cdejxQwgG4vMhZnI7UZ9AITpVkA0xI=; b=BcmJFhj8l1d/LIMEiByUNtjTKahSjivuL+FjZwHL443KMR8NEC04GznBsQjtX2hKJG rksvifmyZFddOZtkH7no43QUgVd0AKKswuKultD6n+WzY5ZWIG1IoqF3AkkCrC4yHEBU iB8K8t0OHCaxJlO85WMcwWSgrEmVjKMWWvFyFh2DM0oz2icyBUVnbkBKe0adGlXX7yLq 8ji+a80aPafv/Z31m4Qdok8kj7tuln8fr9hjqecGhex9c0rbBcvJwvVOF9PAPUQfQ372 pbbnDtP4VKm2qSGpekaMLRtcNrkBqDqvNccGA/pq2l2M/0+L+2efmuH1nqeFOpPBx+Py VntA== X-Gm-Message-State: AE9vXwPvW8Yd+/QRPmm/xiQDmbEtRAu91zi9UP+6DNMofCTHIxS9T8DKQXGi/G2oSTYirIiHMQ2cFU3MwubE2k2t X-Received: by 10.28.214.130 with SMTP id n124mr5175873wmg.37.1472858985907; Fri, 02 Sep 2016 16:29:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.236.231 with HTTP; Fri, 2 Sep 2016 16:29:45 -0700 (PDT) In-Reply-To: <201605041348.u44Dmxd0092688@repo.freebsd.org> References: <201605041348.u44Dmxd0092688@repo.freebsd.org> From: Oliver Pinter Date: Sat, 3 Sep 2016 01:29:45 +0200 Message-ID: Subject: Re: svn commit: r299064 - head/sys/kern To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Sep 2016 23:29:49 -0000 Hi! This commit never gets MFCd back to 10-STABLE. Do you still plan to do it? On 5/4/16, Roger Pau Monn=C3=A9 wrote: > Author: royger > Date: Wed May 4 13:48:59 2016 > New Revision: 299064 > URL: https://svnweb.freebsd.org/changeset/base/299064 > > Log: > rtc: fix inverted resolution check > > The current code in clock_register checks if the newly added clock has = a > resolution value higher than the current one in order to make it the > default, which is wrong. Clocks with a lower resolution value should be > better than ones with a higher resolution value, in fact with the curre= nt > code FreeBSD is always selecting the worse clock. > > Reviewed by: kib jhb jkim > Sponsored by: Citrix Systems R&D > MFC after: 2 weeks > Differential revision: https://reviews.freebsd.org/D6185 > > Modified: > head/sys/kern/subr_rtc.c > > Modified: head/sys/kern/subr_rtc.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/kern/subr_rtc.c Wed May 4 12:51:27 2016 (r299063) > +++ head/sys/kern/subr_rtc.c Wed May 4 13:48:59 2016 (r299064) > @@ -84,7 +84,7 @@ clock_register(device_t dev, long res) / > { > > if (clock_dev !=3D NULL) { > - if (clock_res > res) { > + if (clock_res <=3D res) { > if (bootverbose) > device_printf(dev, "not installed as " > "time-of-day clock: clock %s has higher " > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >