From owner-freebsd-bugs  Sat Nov  2 13:40:07 1996
Return-Path: owner-bugs
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id NAA26189
          for bugs-outgoing; Sat, 2 Nov 1996 13:40:07 -0800 (PST)
Received: (from gnats@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id NAA26180;
          Sat, 2 Nov 1996 13:40:04 -0800 (PST)
Resent-Date: Sat, 2 Nov 1996 13:40:04 -0800 (PST)
Resent-Message-Id: <199611022140.NAA26180@freefall.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-bugs
Resent-Reply-To: FreeBSD-gnats@freefall.FreeBSD.org, gpalmer@freebsd.org
Received: from mutara.noc.webspan.net (gpalmer@mutara.noc.webspan.net [206.154.70.44])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id NAA25222
          for <FreeBSD-gnats-submit@freebsd.org>; Sat, 2 Nov 1996 13:30:51 -0800 (PST)
Received: (from gpalmer@localhost) 
          by mutara.noc.webspan.net (8.7.5/8.6.12) id QAA05307;
          Sat, 2 Nov 1996 16:30:01 -0500 (EST)
Message-Id: <199611022130.QAA05307@mutara.noc.webspan.net>
Date: Sat, 2 Nov 1996 16:30:01 -0500 (EST)
From: gpalmer@freebsd.org
Reply-To: gpalmer@freebsd.org
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: bin/1945: Out of date code/comments in dd
Sender: owner-bugs@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk


>Number:         1945
>Category:       bin
>Synopsis:       Out of date code/comments in dd
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Nov  2 13:40:01 PST 1996
>Last-Modified:
>Originator:     Gary Palmer
>Organization:
Webspan Inc
>Release:        FreeBSD 2.2-current i386
>Environment:

cvs-cur 2654

>Description:

Code/comments in bin/dd/args.c seem to think that lseek takes an int for
an argument, but it takes an `off_t' argument. There is even (as Bruce
would say) a bogus cast in the code to quiet the compiler.

>How-To-Repeat:

Look at args.c around line 167, and dd.c around lines 230 and 278

>Fix:
	
Bring the code into the modern age and use off_t's like it should.

>Audit-Trail:
>Unformatted: