From owner-svn-src-head@FreeBSD.ORG  Mon Aug 12 01:01:29 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 032D1E57;
 Mon, 12 Aug 2013 01:01:29 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: from mail-we0-x234.google.com (mail-we0-x234.google.com
 [IPv6:2a00:1450:400c:c03::234])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id E57912FEE;
 Mon, 12 Aug 2013 01:01:27 +0000 (UTC)
Received: by mail-we0-f180.google.com with SMTP id p61so5033972wes.11
 for <multiple recipients>; Sun, 11 Aug 2013 18:01:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=JEBQL8wyw0FkGTATublHwdRX23uNVFKD/dVYJhQlv6U=;
 b=gWSvpAFUYLcIIhNa23mmpnk2OJjAJQo6pY9rkK39Z3ka5AT4TG5Pll+u7zbRNo56Pk
 6xnzKJzFnQp+E+jPolL7D58+AZPLMipeulXHWP2mgpgKvKcj1VUDonDlHJE1m+ZSVxSW
 x5fXc6DZ10FCRy+YOaEZ1RWNw29GziTn208nN0WwdVs+TlnHs51tKq1zof7NoM6QyGjI
 LdoW2U5WCYGxbWN799J7h0HnHF8r9PiHFa1e2eHZBNue8kbBljzYWHxfKA1Pfu6LHchI
 /mU0b9YzdjRMaV6y5SpXRsfkFH2mSrt3Dr1lQjCEKwy5JVn/H5cRGOFASfgIhgP+yyRh
 kiXA==
MIME-Version: 1.0
X-Received: by 10.194.201.202 with SMTP id kc10mr11419929wjc.1.1376269286198; 
 Sun, 11 Aug 2013 18:01:26 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.217.116.136 with HTTP; Sun, 11 Aug 2013 18:01:26 -0700 (PDT)
In-Reply-To: <E28B06A7-D09C-4CFB-ABCA-CD9FC43E89E6@yahoo.com>
References: <201307190012.r6J0Cg1r027645@svn.freebsd.org>
 <52077D0D.8090607@FreeBSD.org>
 <E28B06A7-D09C-4CFB-ABCA-CD9FC43E89E6@yahoo.com>
Date: Sun, 11 Aug 2013 18:01:26 -0700
X-Google-Sender-Auth: A4l_ptZac6ZacA03JkaWCLP8R9s
Message-ID: <CAJ-Vmon_+RvfAFcKcotGf3yVXG4qRB59pktzip=D02xD6DOZFA@mail.gmail.com>
Subject: Re: svn commit: r253460 - head/sys/dev/mps
From: Adrian Chadd <adrian@freebsd.org>
To: Scott Long <scott4long@yahoo.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-src-head@freebsd.org, Alexander Motin <mav@freebsd.org>,
 src-committers@freebsd.org, Scott Long <scottl@freebsd.org>,
 svn-src-all@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Aug 2013 01:01:29 -0000

On 11 August 2013 14:40, Scott Long <scott4long@yahoo.com> wrote:
> Thanks, I'll look into it.

Yo!

Damnit, I really should create a generic "here's a 64 bit mask for
debug" set of macros we can use elsewhere.

Anyway, you should consider a #define that means you can avoid
actually evaluating the arguments that you pass in. That saves even
more CPU.

Ie:

#ifdef DRV_DEBUG
#define DPRINTF(sc, mask, ...) do { if ( (sc)->sc_debug & mask )
dev_printf(sc->sc_dev, __VA_ARGS__); } while (0)
#else
#define DPRINTF(sc, mask, ...)
#endif



-adrian