From owner-svn-ports-all@freebsd.org Thu Jun 15 02:54:38 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 12C12BFD3BA; Thu, 15 Jun 2017 02:54:38 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from apnoea.adamw.org (apnoea.adamw.org [104.225.5.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "apnoea.adamw.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F8ED83E58; Thu, 15 Jun 2017 02:54:36 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id d049645e TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Wed, 14 Jun 2017 20:54:34 -0600 (MDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: svn commit: r443599 - head/Mk From: Adam Weinberger In-Reply-To: <20170615015635.GA78699@FreeBSD.org> Date: Wed, 14 Jun 2017 20:54:33 -0600 Cc: "Tobias C. Berner" , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <42DEC213-DF22-4BDF-9EA2-876629BA763C@adamw.org> References: <201706142018.v5EKIc8G062340@repo.freebsd.org> <20170615005515.GA26393@FreeBSD.org> <2E7EBFF9-6184-4CCA-BCAF-A3991EAF3A94@adamw.org> <20170615015635.GA78699@FreeBSD.org> To: Alexey Dokuchaev X-Mailer: Apple Mail (2.3273) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jun 2017 02:54:38 -0000 > On 14 Jun, 2017, at 19:56, Alexey Dokuchaev wrote: >=20 > On Wed, Jun 14, 2017 at 07:44:49PM -0600, Adam Weinberger wrote: >>> On 14 Jun, 2017, at 18:55, Alexey Dokuchaev = wrote: >>> On Wed, Jun 14, 2017 at 08:18:38PM +0000, Tobias C. Berner wrote: >>>> New Revision: 443599 >>>> URL: https://svnweb.freebsd.org/changeset/ports/443599 >>>>=20 >>>> Log: >>>> Add note, that WRKDIRPREFIX must not end in '/'. >>>>=20 >>>> PR: 199297 >>>=20 >>> This is stupid, fragile, error-prone appoach that does not even = cover all >>> cases (like shown in the PR) when no paths end in slash but the = problem >>> still occurs. Did you read the analysis of my original problem = carefully >>> enough? It was not about slashes, it was symlinks and realpath. >>>=20 >>> You might not like proposed solution but then think of something = better; >>> computers are smart enough to handle slashes automagically rather = than >>> depend on that unrealiable human beings will follow the rules and = notes. >>=20 >> Okay, but WRKDIRPREFIX still shouldn't end in a slash though, and a >> comment saying not to put a slash at the end is a pretty reasonable = move. >=20 > Oh I don't mind the comment (esp. that I'm not a big fan of = superfluous > slashes appended to directories), but was somewhat disappointed that = my PR > was closed as WONTFIX (works as intended) with no response to analysis = of > the problem, no discussion of the proposed solution, etc. All the = effor > was flushed down the toilet. >=20 > Needless to say, the problem is still there until someone else trips = on it > and opens a similar PR. I agree, WRKDIRPREFIX not ending in / is only tangentially related to = the problem you reported. Consider opening a new PR (199297 turned into a different issue) and = attaching a patch. And there probably is merit to finding out what other = stuff breaks when WRKDIRPREFIX !=3D realpath WRKDIRPREFIX. # Adam --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org