From owner-cvs-src@FreeBSD.ORG Tue Oct 25 16:31:10 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A5E0316A420; Tue, 25 Oct 2005 16:31:10 +0000 (GMT) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.FreeBSD.org (Postfix) with ESMTP id 29C7743D45; Tue, 25 Oct 2005 16:31:10 +0000 (GMT) (envelope-from sam@errno.com) Received: from [10.0.0.200] ([10.0.0.200]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.6) with ESMTP id j9PGV1pU009396 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 25 Oct 2005 09:31:03 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <435E5DB6.5020400@errno.com> Date: Tue, 25 Oct 2005 09:30:46 -0700 From: Sam Leffler User-Agent: Mozilla Thunderbird 1.0.6 (X11/20050927) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Roman Kurakin References: <200509271657.j8RGvj2n015326@repoman.freebsd.org> <20051024072423.GA34909@dragon.NUXI.org> <200510241034.27073.jhb@freebsd.org> <20051025052018.GE55418@dragon.NUXI.org> <435E04AA.3080605@cronyx.ru> In-Reply-To: <435E04AA.3080605@cronyx.ru> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Roman Kurakin , src-committers@FreeBSD.org, John Baldwin , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, obrien@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/cp if_cp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Oct 2005 16:31:10 -0000 Roman Kurakin wrote: > David O'Brien wrote: > >> On Mon, Oct 24, 2005 at 10:34:25AM -0400, John Baldwin wrote: >> >> >>> On Monday 24 October 2005 03:24 am, David O'Brien wrote: >>> >>> >>>> On Tue, Sep 27, 2005 at 04:57:45PM +0000, Roman Kurakin wrote: >>>> >>>> >>>>> rik 2005-09-27 16:57:45 UTC >>>>> FreeBSD src repository >>>>> Modified files: >>>>> sys/dev/cp if_cp.c >>>>> Log: >>>>> Restore if_cp.c 1.27 >>>>> >> >> ... >> >> >>>> You should not have backed out my commit without discussing it with me >>>> and understanding the reason for the change. >>>> Do it again and I *will* be taking it Core. >>>> >>> >>> Looks like he added some function prototypes and moved the cdevsw >>> up. Does i compile now with gcc 4.0? It seems that his changes were >>> a lot simpler and didn't destroy nearly as much CVS history as your >>> changes. It would really be preferable to use simpler solutions >>> rather than destroying version history with really big diffs. >>> >> >> >> Doesn't matter -- it was a clear back out of my recent commit. >> src/MAINTAINERS doesn't list any of these drivers, so what was his >> >> > I do not want to list them in src/MAINTAINERS cause I think it is better > to allow any commits. > Cases such this one is rare. > > Since I didn't get reply from you within a week and I do not like > function relocation and didn't > find explanation from commit log I've backout function relocation, not > fix of forward variable > declaration. > > The commit log didn't state what was the problem variable forward > declaration or/and function > forward declaration. > > rik > >> authority in unilaterally backing out my commit? >> It is also port portable to define static functions early in a file, >> before they are used. Roman, I very much agree with your view on maintainership--when someone is given commit privileges we should trust them to commit changes to any piece of the system. If they are not certain their change is good and/or correct then they should get review (and in many cases review is a good habit regardless). There have been a spate of changes of the above sort that go against this tenet. It's made me stop working on freebsd and I suspect the continued practice will make others find a different place to spend their time. Sam