From owner-cvs-all Mon Oct 16 18: 7: 8 2000 Delivered-To: cvs-all@freebsd.org Received: from fw.wintelcom.net (ns1.wintelcom.net [209.1.153.20]) by hub.freebsd.org (Postfix) with ESMTP id 7B01C37B502; Mon, 16 Oct 2000 18:07:04 -0700 (PDT) Received: (from bright@localhost) by fw.wintelcom.net (8.10.0/8.10.0) id e9H174828798; Mon, 16 Oct 2000 18:07:04 -0700 (PDT) Date: Mon, 16 Oct 2000 18:07:04 -0700 From: Alfred Perlstein To: Andrew Gallatin Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/linux linux_machdep.c Message-ID: <20001016180704.D272@fw.wintelcom.net> References: <200010170025.RAA09772@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.4i In-Reply-To: <200010170025.RAA09772@freefall.freebsd.org>; from gallatin@FreeBSD.org on Mon, Oct 16, 2000 at 05:25:43PM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG * Andrew Gallatin [001016 17:25] wrote: > gallatin 2000/10/16 17:25:43 PDT > > Modified files: > sys/i386/linux linux_machdep.c > Log: > Some linux apps, such as IBM's JDK 1.3, will attempt to mmap thread > stacks near the top of their address space. If their TOS is greater > than vm_maxsaddr, vm_map_growstack() will confuse the thread stack > with the process stack and deliver a SEGV if they attempt to grow the > thread stack past their current stacksize rlimit. To avoid this, > adjust vm_maxsaddr upwards to reflect the current stacksize rlimit > rather than the maximum possible stacksize. It would be better to > adjust the mmap'ed region, but some apps (again, IBM's JDK 1.3) do not > check mmap's return value.. > > This commit (in conjunction with setting MINSIGSTKSZ to 2048 & > rebuilding your kernel and modules) will get IBM's JDK 1.3 working > with FreeBSD at least well enough to run many of the example applets. > > Reviewed by: marcel > Tested by: sto@stat.duke.edu, many others on freebsd-java@ Hrm, IBM-java == gross, buggy.. hack hack hack... ugh, more gross bugs.. hack hack hack... etc... Do you have a contact at IBM to report these bugs to? I know we'll still have to hack around them for a while, but we could apply the cluebat a bit and get them to fix up thier code. Not not checking the return value for mmap is just _wrong_ unless MAP_FIXED is specified. -- -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] "I have the heart of a child; I keep it in a jar on my desk." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message