From owner-svn-src-projects@freebsd.org  Tue Nov 22 13:56:23 2016
Return-Path: <owner-svn-src-projects@freebsd.org>
Delivered-To: svn-src-projects@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E364AC4E931
 for <svn-src-projects@mailman.ysv.freebsd.org>;
 Tue, 22 Nov 2016 13:56:23 +0000 (UTC) (envelope-from ae@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id B069A7AC;
 Tue, 22 Nov 2016 13:56:23 +0000 (UTC) (envelope-from ae@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id uAMDuMtp065163;
 Tue, 22 Nov 2016 13:56:22 GMT (envelope-from ae@FreeBSD.org)
Received: (from ae@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id uAMDuMgQ065162;
 Tue, 22 Nov 2016 13:56:22 GMT (envelope-from ae@FreeBSD.org)
Message-Id: <201611221356.uAMDuMgQ065162@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: ae set sender to ae@FreeBSD.org
 using -f
From: "Andrey V. Elsukov" <ae@FreeBSD.org>
Date: Tue, 22 Nov 2016 13:56:22 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject: svn commit: r308999 - projects/ipsec/sys/netipsec
X-SVN-Group: projects
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
 tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects/>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Nov 2016 13:56:24 -0000

Author: ae
Date: Tue Nov 22 13:56:22 2016
New Revision: 308999
URL: https://svnweb.freebsd.org/changeset/base/308999

Log:
  Update key_getsah() to use SAHADDRHASH and return referenced value.

Modified:
  projects/ipsec/sys/netipsec/key.c

Modified: projects/ipsec/sys/netipsec/key.c
==============================================================================
--- projects/ipsec/sys/netipsec/key.c	Tue Nov 22 13:53:37 2016	(r308998)
+++ projects/ipsec/sys/netipsec/key.c	Tue Nov 22 13:56:22 2016	(r308999)
@@ -2755,27 +2755,28 @@ key_delsav(struct secasvar *sav)
 	uma_zfree(V_key_lft_zone, sav->lft_c);
 	free(sav, M_IPSEC_SA);
 }
+
 /*
- * search SAD.
+ * search SAH.
  * OUT:
  *	NULL	: not found
- *	others	: found, pointer to a SA.
+ *	others	: found, referenced pointer to a SAH.
  */
 static struct secashead *
 key_getsah(struct secasindex *saidx)
 {
+	SAHTREE_RLOCK_TRACKER;
 	struct secashead *sah;
 
-	SAHTREE_LOCK();
-	LIST_FOREACH(sah, &V_sahtree, chain) {
-		if (sah->state == SADB_SASTATE_DEAD)
-			continue;
-		if (key_cmpsaidx(&sah->saidx, saidx, CMP_REQID))
-			break;
+	SAHTREE_RLOCK();
+	LIST_FOREACH(sah, SAHADDRHASH_HASH(saidx), addrhash) {
+	    if (key_cmpsaidx(&sah->saidx, saidx, CMP_MODE_REQID) != 0) {
+		    SAH_ADDREF(sah);
+		    break;
+	    }
 	}
-	SAHTREE_UNLOCK();
-
-	return sah;
+	SAHTREE_RUNLOCK();
+	return (sah);
 }
 
 /*