From owner-svn-src-head@freebsd.org Tue Oct 6 08:06:57 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1626042C039; Tue, 6 Oct 2020 08:06:57 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4C596S574Bz46wj; Tue, 6 Oct 2020 08:06:56 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2020.home.selasky.org (120.89-11-192.nextgentel.com [89.11.192.120]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 7AD082602B9; Tue, 6 Oct 2020 10:06:48 +0200 (CEST) Subject: Re: svn commit: r366471 - head/usr.bin/backlight To: Baptiste Daroussin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202010060805.09685J6l009787@repo.freebsd.org> From: Hans Petter Selasky Message-ID: Date: Tue, 6 Oct 2020 10:06:13 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <202010060805.09685J6l009787@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4C596S574Bz46wj X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2020 08:06:57 -0000 On 2020-10-06 10:05, Baptiste Daroussin wrote: > Author: bapt > Date: Tue Oct 6 08:05:19 2020 > New Revision: 366471 > URL: https://svnweb.freebsd.org/changeset/base/366471 > > Log: > backlight: accept '%' in the brightness input value > > Improve friendlyness of the command line by accepting the percent brightness > in both format: with or without a trailing '%' > > Reviewed by: manu > Differential Revision: https://reviews.freebsd.org/D26692 > > Modified: > head/usr.bin/backlight/backlight.8 > head/usr.bin/backlight/backlight.c > > Modified: head/usr.bin/backlight/backlight.8 > ============================================================================== > --- head/usr.bin/backlight/backlight.8 Tue Oct 6 06:45:52 2020 (r366470) > +++ head/usr.bin/backlight/backlight.8 Tue Oct 6 08:05:19 2020 (r366471) > @@ -22,7 +22,7 @@ > .\" > .\" $FreeBSD$ > .\" > -.Dd October 02, 2020 > +.Dd October 06, 2020 > .Dt BACKLIGHT 8 > .Os > .Sh NAME > @@ -63,6 +63,7 @@ When querying the brightness level only print the valu > Query information about the backlight (name, type). > .It Ar value > Set the brightness level to this value, must be between 0 and 100. > +A trailing '%' is valid. > .It Ar incr | + > .Op Ar value > Decrement the backlight level. > > Modified: head/usr.bin/backlight/backlight.c > ============================================================================== > --- head/usr.bin/backlight/backlight.c Tue Oct 6 06:45:52 2020 (r366470) > +++ head/usr.bin/backlight/backlight.c Tue Oct 6 08:05:19 2020 (r366471) > @@ -144,6 +144,9 @@ main(int argc, char *argv[]) > action = BACKLIGHT_SET_BRIGHTNESS; > > if (argc == 1) { > + /* ignore a trailing % for user friendlyness */ > + if (argv[0][strlen(argv[0]) - 1] == '%') > + argv[0][strlen(argv[0]) - 1] = '\0'; > percent = strtonum(argv[0], 0, 100, &percent_error); > if (percent_error) > errx(1, "Cannot parse brightness level %s: %s", > Should there be a check here that strlen(xxx) > 0 ? --HPS