From owner-svn-src-all@freebsd.org Thu Aug 16 16:23:38 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5AAD5106CCB6; Thu, 16 Aug 2018 16:23:38 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-io0-x241.google.com (mail-io0-x241.google.com [IPv6:2607:f8b0:4001:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CBB718B41E; Thu, 16 Aug 2018 16:23:37 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by mail-io0-x241.google.com with SMTP id x5-v6so4320217iop.13; Thu, 16 Aug 2018 09:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hVlcRa1G89rT1+bszv1W6xDF/xmZ+u4rytJQFdapYoE=; b=nfS/EIVqv6Wxm8w58Amyy4PrOvD5DZmzag+yDt0k5t1JviSAEPRrbmTIs6pFPQDSrm GShstzj5eyvuiio0I+NACkShB4Y8srHZ87beD8O1R91sIMB+PpjGaHhr1O30XL2Twr0f JVuhq71S6T2cbVI45h0uAZvYIAJ1jPqNQg0+N+OfrGNgjLy/0yTCqvTWqto3GW9nYqk0 SkPQlc2JxGjG5FCt4q0fWtLhzgmmTbkNxtVt7RHJFp1eSVvcQi8d4/c2zcAh/VZFrhdS t7/RZTqcuw6BDVEoxYaHdVQc9zmYCychBGPcfEoUE4V0t+JFIsMdwMMudsVdvJTTmFX+ DEJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hVlcRa1G89rT1+bszv1W6xDF/xmZ+u4rytJQFdapYoE=; b=HwLKOanIhixvgtZPPbBLgm4Q+0ilPbTT7+pvDOZ0xK2EH7c9XCCYUQPvEjaFbs2RQG jfxV/ZfyDChBfcDridTvjwRZdAUMILjheO46TcH5Nxqh4jg5kCLpS81aSS6VP0QmEMIS grmyyRIpWoYZlpneFrhhfz5bElaYkJHDCTbfZnFDhEt8IoFz90xFt6ImE/rPvA2MKCx1 TLgrI3oxr8M+M5eYOabFuRMG+mAdI1mtJ/l47Kiis075+LP2mqv6rvbuOcMxqvQcfzBY IdCWmHSqYoIpEDqLgPZvUJ8yhd9JASGZq1HxSoOsrvooPNW3KgZxO3JwnhoPsMekCFzu 32jQ== X-Gm-Message-State: AOUpUlGcJt7Vra7NKYHOtItK8wWiaoqdvmuxBeDY7HeRXiDo1YcqqvUg Dps8ttAeUfgQWncVMbXNUw1GMPPbSezBzA== X-Google-Smtp-Source: AA+uWPwDiRc3i+ryylBzYleIr41zzqZLRthf/Zvvm/dGpXNsk4v68/EkgxLxWROdox2v+16twxNt9Q== X-Received: by 2002:a6b:f305:: with SMTP id m5-v6mr26179632ioh.253.1534436616774; Thu, 16 Aug 2018 09:23:36 -0700 (PDT) Received: from ralga.knownspace (173-25-245-129.client.mchsi.com. [173.25.245.129]) by smtp.gmail.com with ESMTPSA id c3-v6sm660208itd.8.2018.08.16.09.23.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 Aug 2018 09:23:36 -0700 (PDT) Date: Thu, 16 Aug 2018 11:23:31 -0500 From: Justin Hibbits To: Ravi Pokala Cc: Doug Ambrisko , , , Subject: Re: svn commit: r337913 - in head/sys: dev/ipmi modules/ipmi Message-ID: <20180816112331.2d6d638f@ralga.knownspace> In-Reply-To: References: <201808161559.w7GFx3pg061595@repo.freebsd.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; powerpc64-portbld-freebsd12.0) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2018 16:23:38 -0000 Woops, my fault way back when I made powerpc64's IPMI OPAL buildable as a module. Can't believe I had i386 twice in there. - Justin On Thu, 16 Aug 2018 09:11:01 -0700 Ravi Pokala wrote: > The confluence of these two issues is that on amd64 ipmi.ko loads, > but doesn't attach to the BMC or create /dev/ipmi, and that the > kernel panics when trying to unload. Right? >=20 > If so, that's exactly the issue I hit on Monday, but didn't get a > chance to triage. Thanks! >=20 > -Ravi >=20 > =EF=BB=BF-----Original Message----- > From: on behalf of Doug Ambrisko > Date: 2018-08-16, Thursday at 08:59 > To: , , > Subject: svn commit: r337913 - in > head/sys: dev/ipmi modules/ipmi >=20 > Author: ambrisko > Date: Thu Aug 16 15:59:02 2018 > New Revision: 337913 > URL: https://svnweb.freebsd.org/changeset/base/337913 >=20 > Log: > Fix a module Makefile error on amd64 so the IPMI HW interfaces are > built. When the module is being unloaded and no HW interfaces were > created don't clean up. This was exposed by the amd64 module build > issue. >=20 > Modified: > head/sys/dev/ipmi/ipmi.c > head/sys/modules/ipmi/Makefile >=20 > Modified: head/sys/dev/ipmi/ipmi.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/dev/ipmi/ipmi.c Thu Aug 16 15:54:12 2018 > (r337912) +++ head/sys/dev/ipmi/ipmi.c Thu Aug 16 15:59:02 > 2018 (r337913) @@ -1053,6 +1053,8 @@ ipmi_unload(void *arg) > int count; > int i; > =20 > + if (ipmi_devclass =3D=3D NULL) > + return; > if (devclass_get_devices(ipmi_devclass, &devs, &count) !=3D 0) > return; > for (i =3D 0; i < count; i++) >=20 > Modified: head/sys/modules/ipmi/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/modules/ipmi/Makefile Thu Aug 16 15:54:12 > 2018 (r337912) +++ head/sys/modules/ipmi/Makefile Thu > Aug 16 15:59:02 2018 (r337913) @@ -7,7 +7,7 @@ > KMOD=3D ipmi > SRCS=3D ipmi.c > SRCS+=3D bus_if.h device_if.h > -.if ${MACHINE_CPUARCH} =3D=3D "i386" || ${MACHINE_CPUARCH} =3D=3D "i386" > +.if ${MACHINE_CPUARCH} =3D=3D "i386" || ${MACHINE_CPUARCH} =3D=3D "amd64" > SRCS+=3D ipmi_kcs.c ipmi_smic.c ipmi_smbios.c ipmi_ssif.c > SRCS+=3D ipmi_acpi.c ipmi_isa.c ipmi_pci.c ipmi_smbus.c > SRCS+=3D opt_acpi.h >=20 >=20 >=20 >=20