From owner-cvs-src@FreeBSD.ORG  Wed Aug  2 03:37:19 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 71D4716A508
	for <cvs-src@FreeBSD.org>; Wed,  2 Aug 2006 03:37:19 +0000 (UTC)
	(envelope-from qingli@speakeasy.net)
Received: from webmail2.sea5.speakeasy.net (webmail2.speakeasy.net
	[69.17.117.49]) by mx1.FreeBSD.org (Postfix) with ESMTP id B82F443D79
	for <cvs-src@FreeBSD.org>; Wed,  2 Aug 2006 03:37:06 +0000 (GMT)
	(envelope-from qingli@speakeasy.net)
Received: (qmail 16189 invoked from network); 2 Aug 2006 03:37:05 -0000
Received: from localhost (HELO webmail2) ([127.0.0.1])
	(envelope-sender <qingli@speakeasy.net>)
	by localhost (qmail-ldap-1.03) with SMTP
	for <yar@FreeBSD.org>; 2 Aug 2006 03:37:05 -0000
Received: from 12.178.37.11 (unverified [12.178.37.11])
	by webmail2 (VisualMail 4.0) with WEBMAIL id 11007;
	Wed, 02 Aug 2006 03:37:05 +0000
From: "Qing Li" <qingli@speakeasy.net>
To: "Yar Tikhiy" <yar@FreeBSD.org>, "Qing Li" <qingli@FreeBSD.org>
Importance: Normal
Sensitivity: Normal
Message-ID: <W89695191110071154489825@webmail2>
X-Mailer: Mintersoft VisualMail, Build 4.0.111601
X-Originating-IP: [12.178.37.11]
Date: Wed, 02 Aug 2006 03:37:05 +0000
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, sam@FreeBSD.org, src-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re:  cvs commit: src/sys/net if_vlan.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Aug 2006 03:37:19 -0000


> 
> Removing the "dead" assignment to evl->evl_encap_proto above and
> reducing the bcopy window by 2 bytes here is a nano-optimization.
> Which is worse, it smuggles hidden dot1q details in this otherwise
> encapsulation-neutral block of code.  E.g., I could use the former
> code for both dot1q and ISL privately by just redefining
> ETHER_VLAN_ENCAP_LEN.
> 

   You are right.

>
> Grand total:  I would greately appreciate if you backed out this
> change and then fixed the tag value of -1 alone, but let me review
> that first.  Thanks!
> 

   Okay.

   Thanks,

   -- Qing