Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 09 Apr 2014 11:53:06 +0200
From:      John Marino <freebsd.contact@marino.st>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>, Niclas Zeising <zeising@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r350341 - in head/x11-wm/spectrwm: . files
Message-ID:  <53451882.50705@marino.st>
In-Reply-To: <20140409094935.GA32661@FreeBSD.org>
References:  <201404060745.s367j4nR058999@svn.freebsd.org> <20140409094935.GA32661@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 4/9/2014 11:49, Alexey Dokuchaev wrote:
> On Sun, Apr 06, 2014 at 07:45:04AM +0000, Niclas Zeising wrote:
>> New Revision: 350341
>> URL: http://svnweb.freebsd.org/changeset/ports/350341
>> QAT: https://qat.redports.org/buildarchive/r350341/
>>
>> @@ -1,6 +1,6 @@
>> ---- spectrwm.c.orig	2013-04-29 23:55:24.573913339 +0200
>> -+++ spectrwm.c	2013-04-29 23:55:44.031914326 +0200
>> -@@ -6316,7 +6316,7 @@
>> +--- spectrwm.c.orig	2014-04-06 09:43:33.000000000 +0200
>> ++++ spectrwm.c	2014-04-06 09:43:33.000000000 +0200
>> +@@ -7008,7 +7008,7 @@
>>   void
>>   setup_spawn(void)
>>   {
> 
> Guys, (replying to one of the few similar emails)
> 
> Please don't commit changes to patch files that only touch patch header, not
> file contents in any way.  It clutters the commit and jeopardizes "svn blame",
> thank you.


How does this example qualify?
The offset changes by nearly 700 lines.
This is a valid patch change IMO.
Offsets are content.

Regards,
John



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53451882.50705>