From owner-svn-ports-all@FreeBSD.ORG Wed Apr 9 10:07:22 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 868B21C7; Wed, 9 Apr 2014 10:07:22 +0000 (UTC) Date: Wed, 9 Apr 2014 10:07:22 +0000 From: Alexey Dokuchaev To: marino@freebsd.org Subject: Re: svn commit: r350341 - in head/x11-wm/spectrwm: . files Message-ID: <20140409100722.GA38933@FreeBSD.org> References: <201404060745.s367j4nR058999@svn.freebsd.org> <20140409094935.GA32661@FreeBSD.org> <53451882.50705@marino.st> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53451882.50705@marino.st> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Niclas Zeising X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Apr 2014 10:07:22 -0000 On Wed, Apr 09, 2014 at 11:53:06AM +0200, John Marino wrote: > On 4/9/2014 11:49, Alexey Dokuchaev wrote: > > On Sun, Apr 06, 2014 at 07:45:04AM +0000, Niclas Zeising wrote: > >> New Revision: 350341 > >> URL: http://svnweb.freebsd.org/changeset/ports/350341 > >> QAT: https://qat.redports.org/buildarchive/r350341/ > >> > >> @@ -1,6 +1,6 @@ > >> ---- spectrwm.c.orig 2013-04-29 23:55:24.573913339 +0200 > >> -+++ spectrwm.c 2013-04-29 23:55:44.031914326 +0200 > >> -@@ -6316,7 +6316,7 @@ > >> +--- spectrwm.c.orig 2014-04-06 09:43:33.000000000 +0200 > >> ++++ spectrwm.c 2014-04-06 09:43:33.000000000 +0200 > > > > Guys, (replying to one of the few similar emails) > > > > Please don't commit changes to patch files that only touch patch header, not > > file contents in any way. [...] > > How does this example qualify? > The offset changes by nearly 700 lines. > This is a valid patch change IMO. > Offsets are content. Right; mea culpa; sorry for the noise. However, if +++/--- lines were not touched, it would helped to spot the real difference easier. :) ./danfe